comment on PR when example job finds changes (#18064)
# Objective - Comment on PR when getting a rendering change ## Solution - When something changes in the rendering check CI, add a comment on the PR to check the results - Suggest adding the label `S-Deliberate-Rendering-Change` if it's expected - Don't comment if the label is already present --------- Co-authored-by: Alice Cecile <alice.i.cecile@gmail.com>
This commit is contained in:
parent
058497e0bb
commit
0122b85cc3
41
.github/workflows/example-run-report.yml
vendored
41
.github/workflows/example-run-report.yml
vendored
@ -20,6 +20,7 @@ jobs:
|
|||||||
timeout-minutes: 30
|
timeout-minutes: 30
|
||||||
outputs:
|
outputs:
|
||||||
branch-name: ${{ steps.branch-name.outputs.result }}
|
branch-name: ${{ steps.branch-name.outputs.result }}
|
||||||
|
pr-number: ${{ steps.pr-number.outputs.result }}
|
||||||
steps:
|
steps:
|
||||||
- name: "Download artifact"
|
- name: "Download artifact"
|
||||||
id: find-artifact
|
id: find-artifact
|
||||||
@ -59,11 +60,11 @@ jobs:
|
|||||||
- name: branch name
|
- name: branch name
|
||||||
id: branch-name
|
id: branch-name
|
||||||
run: |
|
run: |
|
||||||
if [ -f PR ]; then
|
echo "result=PR-$(cat PR)-${{ github.event.workflow_run.head_branch }}" >> $GITHUB_OUTPUT
|
||||||
echo "result=PR-$(cat PR)-${{ github.event.workflow_run.head_branch }}" >> $GITHUB_OUTPUT
|
- name: PR number
|
||||||
else
|
id: pr-number
|
||||||
echo "result=${{ github.event.workflow_run.head_branch }}" >> $GITHUB_OUTPUT
|
run: |
|
||||||
fi
|
echo "result=$(cat PR)" >> $GITHUB_OUTPUT
|
||||||
|
|
||||||
compare-macos-screenshots:
|
compare-macos-screenshots:
|
||||||
name: Compare macOS screenshots
|
name: Compare macOS screenshots
|
||||||
@ -75,3 +76,33 @@ jobs:
|
|||||||
artifact: screenshots-macos
|
artifact: screenshots-macos
|
||||||
os: macos
|
os: macos
|
||||||
secrets: inherit
|
secrets: inherit
|
||||||
|
|
||||||
|
comment-on-pr:
|
||||||
|
name: Comment on PR
|
||||||
|
runs-on: ubuntu-latest
|
||||||
|
needs: [make-macos-screenshots-available, compare-macos-screenshots]
|
||||||
|
if: ${{ always() && needs.compare-macos-screenshots.result == 'failure' }}
|
||||||
|
steps:
|
||||||
|
- uses: actions/checkout@v4
|
||||||
|
- name: "Check if PR already has label"
|
||||||
|
id: check-label
|
||||||
|
env:
|
||||||
|
PR: ${{ needs.make-macos-screenshots-available.outputs.pr-number }}
|
||||||
|
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
|
||||||
|
run: |
|
||||||
|
if [[ `gh api --jq '.labels.[].name' /repos/bevyengine/bevy/pulls/$PR` =~ "S-Rendering-Change" ]]
|
||||||
|
then
|
||||||
|
echo "result=true" >> $GITHUB_OUTPUT
|
||||||
|
else
|
||||||
|
echo "result=false" >> $GITHUB_OUTPUT
|
||||||
|
fi
|
||||||
|
- name: "Comment on PR"
|
||||||
|
if: ${{ steps.check-label.outputs.result == 'false' }}
|
||||||
|
env:
|
||||||
|
PROJECT: B04F67C0-C054-4A6F-92EC-F599FEC2FD1D
|
||||||
|
PR: ${{ needs.make-macos-screenshots-available.outputs.pr-number }}
|
||||||
|
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
|
||||||
|
run: |
|
||||||
|
LF=$'\n'
|
||||||
|
COMMENT_BODY="Your PR caused a change in the graphical output of an example or rendering test. This might be intentional, but it could also mean that something broke! ${LF}You can review it at https://pixel-eagle.com/project/$PROJECT?filter=PR-$PR ${LF} ${LF}If it's expected, please add the S-Deliberate-Rendering-Change label."
|
||||||
|
gh issue comment $PR --body "$COMMENT_BODY"
|
||||||
|
Loading…
Reference in New Issue
Block a user