forestia/bevy
2
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Diagnostics smoothing factor fix (#17354)

Browse Source 
# Objective

Diagnostics is reporting incorrect FPS and frame time.

## Solution

Looks like the smoothing value should be `2 / (history_length + 1)` not
`(history_length + 1) / 2`.

Co-authored-by: François Mockers <mockersf@gmail.com>
This commit is contained in:
ickshonpe 2025-01-14 01:13:24 +00:00 committed by GitHub
parent c96949dabe
commit 0222b35f6d
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
crates/bevy_diagnostic/src/frame_time_diagnostics_plugin.rs
View File

@ -14,7 +14,7 @@ use bevy_time::{Real, Time};
pub struct FrameTimeDiagnosticsPlugin { pub struct FrameTimeDiagnosticsPlugin {
/// The total number of values to keep for averaging. /// The total number of values to keep for averaging.
pub max_history_length: usize, pub max_history_length: usize,
/// The smoothing factor for the exponential moving average. Usually `(history_length + 1.0) / 2.0)`. /// The smoothing factor for the exponential moving average. Usually `2.0 / (history_length + 1.0)`.
pub smoothing_factor: f64, pub smoothing_factor: f64,
} }
impl Default for FrameTimeDiagnosticsPlugin { impl Default for FrameTimeDiagnosticsPlugin {
@ -28,7 +28,7 @@ impl FrameTimeDiagnosticsPlugin {
pub fn new(max_history_length: usize) -> Self { pub fn new(max_history_length: usize) -> Self {
Self { Self {
max_history_length, max_history_length,
smoothing_factor: (max_history_length as f64 + 1.0) / 2.0, smoothing_factor: 2.0 / (max_history_length as f64 + 1.0),
} }
} }
} }