forestia/bevy
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove Resource and add Debug to TaskPoolOptions (#9485)

Browse Source 
# Objective

PR #6360 changed `TaskPoolOptions` so it is no longer used as a
Resource, but didn't remove the `Resource` derive.

## Solution

Remove the Resource derive from `TaskPoolOptions`, as it is no longer
needed. Also add a Debug derive, because it didn't have it before.

---

## Changelog

- `TaskPoolOptions` no longer derives Resource, and `TaskPoolOptions` &
`TaskPoolThreadAssignmentPolicy` now derive Debug.

## Migration Guide

If for some reason anyone is still using `TaskPoolOptions` as a
Resource, they would now have to use a wrapper type:
```rust
#[derive(Resource)]
pub struct MyTaskPoolOptions(pub TaskPoolOptions);
```
This commit is contained in:
Pixelstorm 2023-08-20 23:32:41 +01:00 committed by GitHub
parent 69750a03ca
commit 02ac5c4c5b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
crates/bevy_core/src/task_pool_options.rs
View File

@ -1,10 +1,9 @@
use bevy_ecs::prelude::Resource;
use bevy_tasks::{AsyncComputeTaskPool, ComputeTaskPool, IoTaskPool, TaskPoolBuilder}; use bevy_tasks::{AsyncComputeTaskPool, ComputeTaskPool, IoTaskPool, TaskPoolBuilder};
use bevy_utils::tracing::trace; use bevy_utils::tracing::trace;
/// Defines a simple way to determine how many threads to use given the number of remaining cores /// Defines a simple way to determine how many threads to use given the number of remaining cores
/// and number of total cores /// and number of total cores
#[derive(Clone)] #[derive(Clone, Debug)]
pub struct TaskPoolThreadAssignmentPolicy { pub struct TaskPoolThreadAssignmentPolicy {
/// Force using at least this many threads /// Force using at least this many threads
pub min_threads: usize, pub min_threads: usize,
@ -33,7 +32,7 @@ impl TaskPoolThreadAssignmentPolicy {
/// Helper for configuring and creating the default task pools. For end-users who want full control, /// Helper for configuring and creating the default task pools. For end-users who want full control,
/// set up [`TaskPoolPlugin`](super::TaskPoolPlugin) /// set up [`TaskPoolPlugin`](super::TaskPoolPlugin)
#[derive(Clone, Resource)] #[derive(Clone, Debug)]
pub struct TaskPoolOptions { pub struct TaskPoolOptions {
/// If the number of physical cores is less than min_total_threads, force using /// If the number of physical cores is less than min_total_threads, force using
/// min_total_threads /// min_total_threads