forestia/bevy
2
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

fix(picking): Location is not a Component anymore. (#19306)

Browse Source 
# Objective

- Fixes #17390

## Solution

- Remove Component derive

## Testing

- cargo clippy
This commit is contained in:
atlv 2025-05-21 21:33:01 -04:00 committed by GitHub
parent 2b59ab8e2d
commit 031fa25ff6
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
crates/bevy_picking/src/pointer.rs
View File

@ -205,8 +205,8 @@ impl PointerLocation {
/// - a pointer is not associated with a [`Camera`] because multiple cameras can target the same /// - a pointer is not associated with a [`Camera`] because multiple cameras can target the same
/// render target. It is up to picking backends to associate a Pointer's `Location` with a /// render target. It is up to picking backends to associate a Pointer's `Location` with a
/// specific `Camera`, if any. /// specific `Camera`, if any.
#[derive(Debug, Clone, Component, Reflect, PartialEq)] #[derive(Debug, Clone, Reflect, PartialEq)]
#[reflect(Component, Debug, PartialEq, Clone)] #[reflect(Debug, PartialEq, Clone)]
pub struct Location { pub struct Location {
/// The [`NormalizedRenderTarget`] associated with the pointer, usually a window. /// The [`NormalizedRenderTarget`] associated with the pointer, usually a window.
pub target: NormalizedRenderTarget, pub target: NormalizedRenderTarget,

6
release-content/migration-guides/picking_location_not_component.md Normal file
View File

@ -0,0 +1,6 @@
---
title: Location is not a Component anymore
pull_requests: [19306]
---
`bevy_picking::Location` was erroneously made a `Component`. It is no longer one, `bevy_picking::PointerLocation` wraps a `Location` and is the intended usage pattern.