forestia/bevy
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

View filter for batch_and_prepare_render_phase (#14713)

Browse Source 
# Objective
- batch_and_prepare_render_phase will iterate all living entities ,which
potentially causes a lot of unnecessary look up
- from
https://github.com/bevyengine/bevy/pull/14449#issuecomment-2282876034

## Solution

- added View filter
This commit is contained in:
re0312 2024-08-13 00:15:54 +08:00 committed by GitHub
parent 61a1530c56
commit 032fd486c7
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
crates/bevy_render/src/batching/gpu_preprocessing.rs
View File

@ -24,7 +24,7 @@ use crate::{
}, },
render_resource::{BufferVec, GpuArrayBufferable, RawBufferVec, UninitBufferVec}, render_resource::{BufferVec, GpuArrayBufferable, RawBufferVec, UninitBufferVec},
renderer::{RenderAdapter, RenderDevice, RenderQueue}, renderer::{RenderAdapter, RenderDevice, RenderQueue},
view::{GpuCulling, ViewTarget}, view::{ExtractedView, GpuCulling, ViewTarget},
Render, RenderApp, RenderSet, Render, RenderApp, RenderSet,
}; };
@ -386,7 +386,7 @@ pub fn batch_and_prepare_sorted_render_phase<I, GFBD>(
gpu_array_buffer: ResMut<BatchedInstanceBuffers<GFBD::BufferData, GFBD::BufferInputData>>, gpu_array_buffer: ResMut<BatchedInstanceBuffers<GFBD::BufferData, GFBD::BufferInputData>>,
mut indirect_parameters_buffer: ResMut<IndirectParametersBuffer>, mut indirect_parameters_buffer: ResMut<IndirectParametersBuffer>,
mut sorted_render_phases: ResMut<ViewSortedRenderPhases<I>>, mut sorted_render_phases: ResMut<ViewSortedRenderPhases<I>>,
mut views: Query<(Entity, Has<GpuCulling>)>, mut views: Query<(Entity, Has<GpuCulling>), With<ExtractedView>>,
system_param_item: StaticSystemParam<GFBD::Param>, system_param_item: StaticSystemParam<GFBD::Param>,
) where ) where
I: CachedRenderPipelinePhaseItem + SortedPhaseItem, I: CachedRenderPipelinePhaseItem + SortedPhaseItem,
@ -503,7 +503,7 @@ pub fn batch_and_prepare_binned_render_phase<BPI, GFBD>(
gpu_array_buffer: ResMut<BatchedInstanceBuffers<GFBD::BufferData, GFBD::BufferInputData>>, gpu_array_buffer: ResMut<BatchedInstanceBuffers<GFBD::BufferData, GFBD::BufferInputData>>,
mut indirect_parameters_buffer: ResMut<IndirectParametersBuffer>, mut indirect_parameters_buffer: ResMut<IndirectParametersBuffer>,
mut binned_render_phases: ResMut<ViewBinnedRenderPhases<BPI>>, mut binned_render_phases: ResMut<ViewBinnedRenderPhases<BPI>>,
mut views: Query<(Entity, Has<GpuCulling>)>, mut views: Query<(Entity, Has<GpuCulling>), With<ExtractedView>>,
param: StaticSystemParam<GFBD::Param>, param: StaticSystemParam<GFBD::Param>,
) where ) where
BPI: BinnedPhaseItem, BPI: BinnedPhaseItem,