forestia/bevy
2
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

add some info from ReflectPathError to the error messages (#5626)

Browse Source 
# Objective

- The `Display` impl for `ReflectPathError` is pretty unspecific (e.g. `the current struct doesn't have a field with the given name`
- it has info for better messages available

## Solution

- make the display impl more descriptive by including values from the type
This commit is contained in:
Jakob Hellermann 2022-08-09 16:53:28 +00:00
parent fe97b384a5
commit 166279e383
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
crates/bevy_reflect/src/path.rs
View File

@ -6,20 +6,20 @@ use thiserror::Error;
/// An error returned from a failed path string query. /// An error returned from a failed path string query.
#[derive(Debug, PartialEq, Eq, Error)] #[derive(Debug, PartialEq, Eq, Error)]
pub enum ReflectPathError<'a> { pub enum ReflectPathError<'a> {
#[error("expected an identifier at the given index")] #[error("expected an identifier at index {index}")]
ExpectedIdent { index: usize }, ExpectedIdent { index: usize },
#[error("the current struct doesn't have a field with the given name")] #[error("the current struct doesn't have a field with the name `{field}`")]
InvalidField { index: usize, field: &'a str }, InvalidField { index: usize, field: &'a str },
#[error("the current tuple struct doesn't have a field with the given index")] #[error("the current tuple struct doesn't have a field with the index {tuple_struct_index}")]
InvalidTupleStructIndex { InvalidTupleStructIndex {
index: usize, index: usize,
tuple_struct_index: usize, tuple_struct_index: usize,
}, },
#[error("the current list doesn't have a value at the given index")] #[error("the current list doesn't have a value at the index {list_index}")]
InvalidListIndex { index: usize, list_index: usize }, InvalidListIndex { index: usize, list_index: usize },
#[error("encountered an unexpected token")] #[error("encountered an unexpected token `{token}`")]
UnexpectedToken { index: usize, token: &'a str }, UnexpectedToken { index: usize, token: &'a str },
#[error("expected a token, but it wasn't there.")] #[error("expected token `{token}`, but it wasn't there.")]
ExpectedToken { index: usize, token: &'a str }, ExpectedToken { index: usize, token: &'a str },
#[error("expected a struct, but found a different reflect value")] #[error("expected a struct, but found a different reflect value")]
ExpectedStruct { index: usize }, ExpectedStruct { index: usize },