Revert some unnecessary changes

This commit is contained in:
Tim Blackbird 2025-07-17 16:24:45 +02:00
parent 42232dd087
commit 1b1283a6f8

View File

@ -1,7 +1,7 @@
use core::hint::black_box; use core::hint::black_box;
use bevy_ecs::{ use bevy_ecs::{
event::{BroadcastEvent, EntityEvent, Event}, event::{BroadcastEvent, EntityEvent},
observer::{On, TriggerTargets}, observer::{On, TriggerTargets},
world::World, world::World,
}; };
@ -13,12 +13,11 @@ fn deterministic_rand() -> ChaCha8Rng {
ChaCha8Rng::seed_from_u64(42) ChaCha8Rng::seed_from_u64(42)
} }
#[derive(Clone, BroadcastEvent)]
struct BroadcastEventBase;
#[derive(Clone, EntityEvent)] #[derive(Clone, EntityEvent)]
struct EventBase; struct EventBase;
impl BroadcastEvent for EventBase {}
pub fn observe_simple(criterion: &mut Criterion) { pub fn observe_simple(criterion: &mut Criterion) {
let mut group = criterion.benchmark_group("observe"); let mut group = criterion.benchmark_group("observe");
group.warm_up_time(core::time::Duration::from_millis(500)); group.warm_up_time(core::time::Duration::from_millis(500));
@ -26,10 +25,10 @@ pub fn observe_simple(criterion: &mut Criterion) {
group.bench_function("trigger_simple", |bencher| { group.bench_function("trigger_simple", |bencher| {
let mut world = World::new(); let mut world = World::new();
world.add_observer(empty_listener::<BroadcastEventBase>); world.add_observer(empty_listener_base);
bencher.iter(|| { bencher.iter(|| {
for _ in 0..10000 { for _ in 0..10000 {
world.trigger(BroadcastEventBase); world.trigger(EventBase);
} }
}); });
}); });
@ -38,12 +37,7 @@ pub fn observe_simple(criterion: &mut Criterion) {
let mut world = World::new(); let mut world = World::new();
let mut entities = vec![]; let mut entities = vec![];
for _ in 0..10000 { for _ in 0..10000 {
entities.push( entities.push(world.spawn_empty().observe(empty_listener_base).id());
world
.spawn_empty()
.observe(empty_listener::<EventBase>)
.id(),
);
} }
entities.shuffle(&mut deterministic_rand()); entities.shuffle(&mut deterministic_rand());
bencher.iter(|| { bencher.iter(|| {
@ -54,7 +48,7 @@ pub fn observe_simple(criterion: &mut Criterion) {
group.finish(); group.finish();
} }
fn empty_listener<E: Event>(trigger: On<E>) { fn empty_listener_base(trigger: On<EventBase>) {
black_box(trigger); black_box(trigger);
} }