forestia/bevy
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix clippy warning about unnecessary return in single_threaded_taks_pool.rs (#18472)

Browse Source 
# Objective

Every time I run `cargo clippy -p bevy_ecs` it pops up and it's
distracting.

## Solution

Removed unnecessary returns. The blocks themselves are necessary or the
`#[cfg(...)]` doesn't apply properly

## Testing

`cargo clippy -p bevy_ecs` + ci build tests
This commit is contained in:
Brezak 2025-03-22 10:03:29 +01:00 committed by GitHub
parent 716fc8b54b
commit 1b82f1fae8
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
crates/bevy_tasks/src/single_threaded_task_pool.rs
View File

@ -201,23 +201,23 @@ impl TaskPool {
{ {
cfg_if::cfg_if! { cfg_if::cfg_if! {
if #[cfg(all(target_arch = "wasm32", feature = "web"))] { if #[cfg(all(target_arch = "wasm32", feature = "web"))] {
return Task::wrap_future(future); Task::wrap_future(future)
} else if #[cfg(feature = "std")] { } else if #[cfg(feature = "std")] {
return LOCAL_EXECUTOR.with(|executor| { LOCAL_EXECUTOR.with(|executor| {
let task = executor.spawn(future); let task = executor.spawn(future);
// Loop until all tasks are done // Loop until all tasks are done
while executor.try_tick() {} while executor.try_tick() {}
Task::new(task) Task::new(task)
}); })
} else { } else {
return { {
let task = LOCAL_EXECUTOR.spawn(future); let task = LOCAL_EXECUTOR.spawn(future);
// Loop until all tasks are done // Loop until all tasks are done
while LOCAL_EXECUTOR.try_tick() {} while LOCAL_EXECUTOR.try_tick() {}
Task::new(task) Task::new(task)
}; }
} }
} }
} }