From 1c838ff6b3989759012f3afcb6db920a2270caa7 Mon Sep 17 00:00:00 2001 From: Lee-Orr Date: Sun, 16 Jun 2024 12:06:45 -0400 Subject: [PATCH] remove inaccurate warning from `in_state` (#13862) # Objective Fixes #13854 ## Solution Removed the inaccurate warning. This was done for a few reasons: - States not existing is now a valid "state" (for lack of a better term) - Other run conditions don't provide an equivalent warning --- crates/bevy_state/src/condition.rs | 17 ++--------------- 1 file changed, 2 insertions(+), 15 deletions(-) diff --git a/crates/bevy_state/src/condition.rs b/crates/bevy_state/src/condition.rs index c0ff5abe49..fb836e1285 100644 --- a/crates/bevy_state/src/condition.rs +++ b/crates/bevy_state/src/condition.rs @@ -1,7 +1,5 @@ -use bevy_ecs::{change_detection::DetectChanges, system::Res}; -use bevy_utils::warn_once; - use crate::state::{State, States}; +use bevy_ecs::{change_detection::DetectChanges, system::Res}; /// A [`Condition`](bevy_ecs::prelude::Condition)-satisfying system that returns `true` /// if the state machine exists. @@ -99,18 +97,7 @@ pub fn state_exists(current_state: Option>>) -> bool { pub fn in_state(state: S) -> impl FnMut(Option>>) -> bool + Clone { move |current_state: Option>>| match current_state { Some(current_state) => *current_state == state, - None => { - warn_once!("No state matching the type for {} exists - did you forget to `init_state` when initializing the app?", { - let debug_state = format!("{state:?}"); - let result = debug_state - .split("::") - .next() - .unwrap_or("Unknown State Type"); - result.to_string() - }); - - false - } + None => false, } }