forestia/bevy
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Apply suggestions from code review

Browse Source 
Co-authored-by: urben1680 <55257931+urben1680@users.noreply.github.com>
This commit is contained in:
Eagster 2025-07-09 08:04:37 -04:00 committed by GitHub
parent 5085d4f5a9
commit 20386ff70e
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
crates/bevy_ecs/src/entity/mod.rs
View File

@ -897,7 +897,7 @@ impl<'a> core::iter::FusedIterator for AllocEntitiesIterator<'a> {}
// SAFETY: Newly allocated entity values are unique. // SAFETY: Newly allocated entity values are unique.
unsafe impl EntitySetIterator for AllocEntitiesIterator<'_> {} unsafe impl EntitySetIterator for AllocEntitiesIterator<'_> {}
/// [`Entities`] tracks all know [`EntityRow`]s and their metadata. /// [`Entities`] tracks all known [`EntityRow`]s and their metadata.
/// This is like a base table of information all entities have. /// This is like a base table of information all entities have.
#[derive(Debug, Clone)] #[derive(Debug, Clone)]
pub struct Entities { pub struct Entities {
@ -1009,8 +1009,7 @@ impl Entities {
pub fn is_row_constructed(&self, row: EntityRow) -> bool { pub fn is_row_constructed(&self, row: EntityRow) -> bool {
self.meta self.meta
.get(row.index() as usize) .get(row.index() as usize)
.map(|meta| meta.location.is_some()) .is_some_and(|meta| meta.location.is_some())
.unwrap_or_default()
} }
/// Returns true if the entity exists. /// Returns true if the entity exists.
@ -1043,7 +1042,7 @@ impl Entities {
/// Returns the previous location of the row. /// Returns the previous location of the row.
/// ///
/// # Safety /// # Safety
/// - The current location of the `row` must already be set. If not, try [`declare`](Self::declare). /// - The current location of the `row` must already be set. If not, use [`declare`](Self::declare).
/// - `location` must be valid for the entity at `row` or immediately made valid afterwards /// - `location` must be valid for the entity at `row` or immediately made valid afterwards
/// before handing control to unknown code. /// before handing control to unknown code.
#[inline] #[inline]
@ -1062,7 +1061,7 @@ impl Entities {
/// Returns the previous location of the row. /// Returns the previous location of the row.
/// ///
/// # Safety /// # Safety
/// - `location` must be valid for the entity at `index` or immediately made valid afterwards /// - `location` must be valid for the entity at `row` or immediately made valid afterwards
/// before handing control to unknown code. /// before handing control to unknown code.
#[inline] #[inline]
pub(crate) unsafe fn declare( pub(crate) unsafe fn declare(