From 21c1b6a1e826290be12e510eb713f4f712a7c4d0 Mon Sep 17 00:00:00 2001 From: MichiRecRoom <1008889+LikeLakers2@users.noreply.github.com> Date: Mon, 6 Jan 2025 00:40:08 -0500 Subject: [PATCH] Update all previously-merged `#![deny(clippy::allow_attributes, clippy::allow_attributes_without_reason)]` attributes to include a reason field pointing to the tracking issue (#17136) # Objective Ensure the deny lint attributes added as a result of #17111 point to the tracking issue. ## Solution Change all existing instances of: ```rust #![deny(clippy::allow_attributes, clippy::allow_attributes_without_reason)] ``` to ```rust #![deny( clippy::allow_attributes, clippy::allow_attributes_without_reason, reason = "See #17111; To be removed once all crates are in-line with these attributes" )] ``` ## Testing N/A --- crates/bevy_a11y/src/lib.rs | 6 +++++- crates/bevy_animation/src/lib.rs | 6 +++++- crates/bevy_app/src/lib.rs | 6 +++++- crates/bevy_math/src/lib.rs | 6 +++++- crates/bevy_tasks/src/lib.rs | 6 +++++- 5 files changed, 25 insertions(+), 5 deletions(-) diff --git a/crates/bevy_a11y/src/lib.rs b/crates/bevy_a11y/src/lib.rs index 43d471d3dc..a0759303e0 100644 --- a/crates/bevy_a11y/src/lib.rs +++ b/crates/bevy_a11y/src/lib.rs @@ -1,5 +1,9 @@ #![forbid(unsafe_code)] -#![deny(clippy::allow_attributes, clippy::allow_attributes_without_reason)] +#![deny( + clippy::allow_attributes, + clippy::allow_attributes_without_reason, + reason = "See #17111; To be removed once all crates are in-line with these attributes" +)] #![cfg_attr(docsrs, feature(doc_auto_cfg))] #![doc( html_logo_url = "https://bevyengine.org/assets/icon.png", diff --git a/crates/bevy_animation/src/lib.rs b/crates/bevy_animation/src/lib.rs index aeadc5233f..feb0a327d6 100644 --- a/crates/bevy_animation/src/lib.rs +++ b/crates/bevy_animation/src/lib.rs @@ -1,6 +1,10 @@ #![cfg_attr(docsrs, feature(doc_auto_cfg))] #![forbid(unsafe_code)] -#![deny(clippy::allow_attributes, clippy::allow_attributes_without_reason)] +#![deny( + clippy::allow_attributes, + clippy::allow_attributes_without_reason, + reason = "See #17111; To be removed once all crates are in-line with these attributes" +)] #![doc( html_logo_url = "https://bevyengine.org/assets/icon.png", html_favicon_url = "https://bevyengine.org/assets/icon.png" diff --git a/crates/bevy_app/src/lib.rs b/crates/bevy_app/src/lib.rs index 48aa26ec51..cf22fa897e 100644 --- a/crates/bevy_app/src/lib.rs +++ b/crates/bevy_app/src/lib.rs @@ -7,7 +7,11 @@ )] #![cfg_attr(any(docsrs, docsrs_dep), feature(doc_auto_cfg, rustdoc_internals))] #![forbid(unsafe_code)] -#![deny(clippy::allow_attributes, clippy::allow_attributes_without_reason)] +#![deny( + clippy::allow_attributes, + clippy::allow_attributes_without_reason, + reason = "See #17111; To be removed once all crates are in-line with these attributes" +)] #![doc( html_logo_url = "https://bevyengine.org/assets/icon.png", html_favicon_url = "https://bevyengine.org/assets/icon.png" diff --git a/crates/bevy_math/src/lib.rs b/crates/bevy_math/src/lib.rs index b66dffcf56..8c758154ef 100644 --- a/crates/bevy_math/src/lib.rs +++ b/crates/bevy_math/src/lib.rs @@ -1,5 +1,9 @@ #![forbid(unsafe_code)] -#![deny(clippy::allow_attributes, clippy::allow_attributes_without_reason)] +#![deny( + clippy::allow_attributes, + clippy::allow_attributes_without_reason, + reason = "See #17111; To be removed once all crates are in-line with these attributes" +)] #![cfg_attr( any(docsrs, docsrs_dep), expect( diff --git a/crates/bevy_tasks/src/lib.rs b/crates/bevy_tasks/src/lib.rs index 1cd6d6786e..16ff97bd74 100644 --- a/crates/bevy_tasks/src/lib.rs +++ b/crates/bevy_tasks/src/lib.rs @@ -4,7 +4,11 @@ html_logo_url = "https://bevyengine.org/assets/icon.png", html_favicon_url = "https://bevyengine.org/assets/icon.png" )] -#![deny(clippy::allow_attributes, clippy::allow_attributes_without_reason)] +#![deny( + clippy::allow_attributes, + clippy::allow_attributes_without_reason, + reason = "See #17111; To be removed once all crates are in-line with these attributes" +)] #![no_std] #[cfg(feature = "std")]