forestia/bevy
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Do not require mut on ParsedPath::element_mut (#8891)

Browse Source 
# Objective

`ParsedPath` does not need to be mut to access a field of a `Reflect`.
Be that access mutable or not. Yet `element_mut` requires a mutable
borrow on `self`.

## Solution

- Make `element_mut` take a `&self` over a `&mut self`.

#8887 fixes this, but this is a major limitation in the API and I'd
rather see it merged before 0.11.

---

## Changelog

- `ParsedPath::element_mut` and `ParsedPath::reflect_element_mut` now
accept a non-mutable `ParsedPath` (only the accessed `Reflect` needs to
be mutable)
This commit is contained in:
Nicola Papale 2023-06-19 17:27:45 +02:00 committed by GitHub
parent e6b655fb25
commit 23863d526a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
crates/bevy_reflect/src/path.rs
View File

@ -371,7 +371,7 @@ impl ParsedPath {
/// ///
/// See [`element_mut`](Self::element_mut) for a typed version of this method. /// See [`element_mut`](Self::element_mut) for a typed version of this method.
pub fn reflect_element_mut<'r, 'p>( pub fn reflect_element_mut<'r, 'p>(
&'p mut self, &'p self,
root: &'r mut dyn Reflect, root: &'r mut dyn Reflect,
) -> Result<&'r mut dyn Reflect, ReflectPathError<'p>> { ) -> Result<&'r mut dyn Reflect, ReflectPathError<'p>> {
let mut current = root; let mut current = root;
@ -402,7 +402,7 @@ impl ParsedPath {
/// ///
/// See [`reflect_element_mut`](Self::reflect_element_mut) for an untyped version of this method. /// See [`reflect_element_mut`](Self::reflect_element_mut) for an untyped version of this method.
pub fn element_mut<'r, 'p, T: Reflect>( pub fn element_mut<'r, 'p, T: Reflect>(
&'p mut self, &'p self,
root: &'r mut dyn Reflect, root: &'r mut dyn Reflect,
) -> Result<&'r mut T, ReflectPathError<'p>> { ) -> Result<&'r mut T, ReflectPathError<'p>> {
self.reflect_element_mut(root).and_then(|p| { self.reflect_element_mut(root).and_then(|p| {