# Objective Fixes #14248 and other URL issues. ## Solution - Describe the solution used to achieve the objective above. Removed the random #s in the URL. Led users to the wrong page. For example, https://bevyengine.org/learn/errors/#b0003 takes users to https://bevyengine.org/learn/errors/introduction, which is not the right page. Removing the #s fixes it. ## Testing - Did you test these changes? If so, how? I pasted the URL into my address bar and it took me to the right place. - Are there any parts that need more testing? No
This commit is contained in:
		
							parent
							
								
									291db3e755
								
							
						
					
					
						commit
						2414311079
					
				
							
								
								
									
										2
									
								
								.github/contributing/engine_style_guide.md
									
									
									
									
										vendored
									
									
								
							
							
						
						
									
										2
									
								
								.github/contributing/engine_style_guide.md
									
									
									
									
										vendored
									
									
								
							| @ -14,7 +14,7 @@ For more advice on contributing to the engine, see the [relevant section](../../ | |||||||
|    4. Use \`variable_name\` code blocks in comments to signify that you're referring to specific types and variables. |    4. Use \`variable_name\` code blocks in comments to signify that you're referring to specific types and variables. | ||||||
|    5. Start comments with capital letters. End them with a period if they are sentence-like. |    5. Start comments with capital letters. End them with a period if they are sentence-like. | ||||||
| 3. Use comments to organize long and complex stretches of code that can't sensibly be refactored into separate functions. | 3. Use comments to organize long and complex stretches of code that can't sensibly be refactored into separate functions. | ||||||
| 4. When using [Bevy error codes](https://bevyengine.org/learn/errors/) include a link to the relevant error on the Bevy website in the returned error message `... See: https://bevyengine.org/learn/errors/#b0003`. | 4. When using [Bevy error codes](https://bevyengine.org/learn/errors/) include a link to the relevant error on the Bevy website in the returned error message `... See: https://bevyengine.org/learn/errors/b0003`. | ||||||
| 
 | 
 | ||||||
| ## Rust API guidelines | ## Rust API guidelines | ||||||
| 
 | 
 | ||||||
|  | |||||||
| @ -195,7 +195,7 @@ fn insert_reflect( | |||||||
|         .expect("component should represent a type."); |         .expect("component should represent a type."); | ||||||
|     let type_path = type_info.type_path(); |     let type_path = type_info.type_path(); | ||||||
|     let Some(mut entity) = world.get_entity_mut(entity) else { |     let Some(mut entity) = world.get_entity_mut(entity) else { | ||||||
|         panic!("error[B0003]: Could not insert a reflected component (of type {type_path}) for entity {entity:?} because it doesn't exist in this World. See: https://bevyengine.org/learn/errors/#b0003"); |         panic!("error[B0003]: Could not insert a reflected component (of type {type_path}) for entity {entity:?} because it doesn't exist in this World. See: https://bevyengine.org/learn/errors/b0003"); | ||||||
|     }; |     }; | ||||||
|     let Some(type_registration) = type_registry.get_with_type_path(type_path) else { |     let Some(type_registration) = type_registry.get_with_type_path(type_path) else { | ||||||
|         panic!("Could not get type registration (for component type {type_path}) because it doesn't exist in the TypeRegistry."); |         panic!("Could not get type registration (for component type {type_path}) because it doesn't exist in the TypeRegistry."); | ||||||
|  | |||||||
| @ -1231,7 +1231,7 @@ fn insert<T: Bundle>(bundle: T) -> impl EntityCommand { | |||||||
|         if let Some(mut entity) = world.get_entity_mut(entity) { |         if let Some(mut entity) = world.get_entity_mut(entity) { | ||||||
|             entity.insert(bundle); |             entity.insert(bundle); | ||||||
|         } else { |         } else { | ||||||
|             panic!("error[B0003]: Could not insert a bundle (of type `{}`) for entity {:?} because it doesn't exist in this World. See: https://bevyengine.org/learn/errors/#b0003", std::any::type_name::<T>(), entity); |             panic!("error[B0003]: Could not insert a bundle (of type `{}`) for entity {:?} because it doesn't exist in this World. See: https://bevyengine.org/learn/errors/b0003", std::any::type_name::<T>(), entity); | ||||||
|         } |         } | ||||||
|     } |     } | ||||||
| } | } | ||||||
|  | |||||||
| @ -299,7 +299,7 @@ fn assert_component_access_compatibility( | |||||||
|         .map(|component_id| world.components.get_info(component_id).unwrap().name()) |         .map(|component_id| world.components.get_info(component_id).unwrap().name()) | ||||||
|         .collect::<Vec<&str>>(); |         .collect::<Vec<&str>>(); | ||||||
|     let accesses = conflicting_components.join(", "); |     let accesses = conflicting_components.join(", "); | ||||||
|     panic!("error[B0001]: Query<{query_type}, {filter_type}> in system {system_name} accesses component(s) {accesses} in a way that conflicts with a previous system parameter. Consider using `Without<T>` to create disjoint Queries or merging conflicting Queries into a `ParamSet`. See: https://bevyengine.org/learn/errors/#b0001"); |     panic!("error[B0001]: Query<{query_type}, {filter_type}> in system {system_name} accesses component(s) {accesses} in a way that conflicts with a previous system parameter. Consider using `Without<T>` to create disjoint Queries or merging conflicting Queries into a `ParamSet`. See: https://bevyengine.org/learn/errors/b0001"); | ||||||
| } | } | ||||||
| 
 | 
 | ||||||
| /// A collection of potentially conflicting [`SystemParam`]s allowed by disjoint access.
 | /// A collection of potentially conflicting [`SystemParam`]s allowed by disjoint access.
 | ||||||
| @ -503,7 +503,7 @@ unsafe impl<'a, T: Resource> SystemParam for Res<'a, T> { | |||||||
|         let combined_access = system_meta.component_access_set.combined_access(); |         let combined_access = system_meta.component_access_set.combined_access(); | ||||||
|         assert!( |         assert!( | ||||||
|             !combined_access.has_write(component_id), |             !combined_access.has_write(component_id), | ||||||
|             "error[B0002]: Res<{}> in system {} conflicts with a previous ResMut<{0}> access. Consider removing the duplicate access. See: https://bevyengine.org/learn/errors/#b0002", |             "error[B0002]: Res<{}> in system {} conflicts with a previous ResMut<{0}> access. Consider removing the duplicate access. See: https://bevyengine.org/learn/errors/b0002", | ||||||
|             std::any::type_name::<T>(), |             std::any::type_name::<T>(), | ||||||
|             system_meta.name, |             system_meta.name, | ||||||
|         ); |         ); | ||||||
| @ -595,11 +595,11 @@ unsafe impl<'a, T: Resource> SystemParam for ResMut<'a, T> { | |||||||
|         let combined_access = system_meta.component_access_set.combined_access(); |         let combined_access = system_meta.component_access_set.combined_access(); | ||||||
|         if combined_access.has_write(component_id) { |         if combined_access.has_write(component_id) { | ||||||
|             panic!( |             panic!( | ||||||
|                 "error[B0002]: ResMut<{}> in system {} conflicts with a previous ResMut<{0}> access. Consider removing the duplicate access. See: https://bevyengine.org/learn/errors/#b0002", |                 "error[B0002]: ResMut<{}> in system {} conflicts with a previous ResMut<{0}> access. Consider removing the duplicate access. See: https://bevyengine.org/learn/errors/b0002", | ||||||
|                 std::any::type_name::<T>(), system_meta.name); |                 std::any::type_name::<T>(), system_meta.name); | ||||||
|         } else if combined_access.has_read(component_id) { |         } else if combined_access.has_read(component_id) { | ||||||
|             panic!( |             panic!( | ||||||
|                 "error[B0002]: ResMut<{}> in system {} conflicts with a previous Res<{0}> access. Consider removing the duplicate access. See: https://bevyengine.org/learn/errors/#b0002", |                 "error[B0002]: ResMut<{}> in system {} conflicts with a previous Res<{0}> access. Consider removing the duplicate access. See: https://bevyengine.org/learn/errors/b0002", | ||||||
|                 std::any::type_name::<T>(), system_meta.name); |                 std::any::type_name::<T>(), system_meta.name); | ||||||
|         } |         } | ||||||
|         system_meta |         system_meta | ||||||
| @ -1133,7 +1133,7 @@ unsafe impl<'a, T: 'static> SystemParam for NonSend<'a, T> { | |||||||
|         let combined_access = system_meta.component_access_set.combined_access(); |         let combined_access = system_meta.component_access_set.combined_access(); | ||||||
|         assert!( |         assert!( | ||||||
|             !combined_access.has_write(component_id), |             !combined_access.has_write(component_id), | ||||||
|             "error[B0002]: NonSend<{}> in system {} conflicts with a previous mutable resource access ({0}). Consider removing the duplicate access. See: https://bevyengine.org/learn/errors/#b0002", |             "error[B0002]: NonSend<{}> in system {} conflicts with a previous mutable resource access ({0}). Consider removing the duplicate access. See: https://bevyengine.org/learn/errors/b0002", | ||||||
|             std::any::type_name::<T>(), |             std::any::type_name::<T>(), | ||||||
|             system_meta.name, |             system_meta.name, | ||||||
|         ); |         ); | ||||||
| @ -1222,11 +1222,11 @@ unsafe impl<'a, T: 'static> SystemParam for NonSendMut<'a, T> { | |||||||
|         let combined_access = system_meta.component_access_set.combined_access(); |         let combined_access = system_meta.component_access_set.combined_access(); | ||||||
|         if combined_access.has_write(component_id) { |         if combined_access.has_write(component_id) { | ||||||
|             panic!( |             panic!( | ||||||
|                 "error[B0002]: NonSendMut<{}> in system {} conflicts with a previous mutable resource access ({0}). Consider removing the duplicate access. See: https://bevyengine.org/learn/errors/#b0002", |                 "error[B0002]: NonSendMut<{}> in system {} conflicts with a previous mutable resource access ({0}). Consider removing the duplicate access. See: https://bevyengine.org/learn/errors/b0002", | ||||||
|                 std::any::type_name::<T>(), system_meta.name); |                 std::any::type_name::<T>(), system_meta.name); | ||||||
|         } else if combined_access.has_read(component_id) { |         } else if combined_access.has_read(component_id) { | ||||||
|             panic!( |             panic!( | ||||||
|                 "error[B0002]: NonSendMut<{}> in system {} conflicts with a previous immutable resource access ({0}). Consider removing the duplicate access. See: https://bevyengine.org/learn/errors/#b0002", |                 "error[B0002]: NonSendMut<{}> in system {} conflicts with a previous immutable resource access ({0}). Consider removing the duplicate access. See: https://bevyengine.org/learn/errors/b0002", | ||||||
|                 std::any::type_name::<T>(), system_meta.name); |                 std::any::type_name::<T>(), system_meta.name); | ||||||
|         } |         } | ||||||
|         system_meta |         system_meta | ||||||
|  | |||||||
| @ -1104,7 +1104,7 @@ impl World { | |||||||
|             entity.despawn(); |             entity.despawn(); | ||||||
|             true |             true | ||||||
|         } else { |         } else { | ||||||
|             warn!("error[B0003]: Could not despawn entity {:?} because it doesn't exist in this World. See: https://bevyengine.org/learn/errors/#b0003", entity); |             warn!("error[B0003]: Could not despawn entity {:?} because it doesn't exist in this World. See: https://bevyengine.org/learn/errors/b0003", entity); | ||||||
|             false |             false | ||||||
|         } |         } | ||||||
|     } |     } | ||||||
|  | |||||||
| @ -66,7 +66,7 @@ pub fn check_hierarchy_component_has_valid_parent<T: Component>( | |||||||
|             already_diagnosed.insert(entity); |             already_diagnosed.insert(entity); | ||||||
|             bevy_utils::tracing::warn!( |             bevy_utils::tracing::warn!( | ||||||
|                 "warning[B0004]: {name} with the {ty_name} component has a parent without {ty_name}.\n\ |                 "warning[B0004]: {name} with the {ty_name} component has a parent without {ty_name}.\n\ | ||||||
|                 This will cause inconsistent behaviors! See: https://bevyengine.org/learn/errors/#b0004",
 |                 This will cause inconsistent behaviors! See: https://bevyengine.org/learn/errors/b0004",
 | ||||||
|                 ty_name = get_short_name(std::any::type_name::<T>()), |                 ty_name = get_short_name(std::any::type_name::<T>()), | ||||||
|                 name = name.map_or_else(|| format!("Entity {}", entity), |s| format!("The {s} entity")), |                 name = name.map_or_else(|| format!("Entity {}", entity), |s| format!("The {s} entity")), | ||||||
|             ); |             ); | ||||||
|  | |||||||
		Loading…
	
		Reference in New Issue
	
	Block a user
	 Blake Bedford
						Blake Bedford