forestia/bevy
2
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

fast-fail in as_bind_group (#12513)

Browse Source 
# Objective

prevent gpu buffer allocations when running `as_bind_group` for assets
with texture dependencies that are not yet available.

## Solution

reorder the binding creation so that fallible items are created first.
This commit is contained in:
robtfm 2024-03-18 17:47:31 +00:00 committed by GitHub
parent 3549ae9e37
commit 26f2d3fb2f
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
crates/bevy_render/macros/src/as_bind_group.rs
View File

@ -272,7 +272,8 @@ pub fn derive_as_bind_group(ast: syn::DeriveInput) -> Result<TokenStream> {
let fallback_image = get_fallback_image(&render_path, dimension); let fallback_image = get_fallback_image(&render_path, dimension);
binding_impls.push(quote! { // insert fallible texture-based entries at 0 so that if we fail here, we exit before allocating any buffers
binding_impls.insert(0, quote! {
( #binding_index, ( #binding_index,
#render_path::render_resource::OwnedBindingResource::TextureView({ #render_path::render_resource::OwnedBindingResource::TextureView({
let handle: Option<&#asset_path::Handle<#render_path::texture::Image>> = (&self.#field_name).into(); let handle: Option<&#asset_path::Handle<#render_path::texture::Image>> = (&self.#field_name).into();
@ -311,7 +312,8 @@ pub fn derive_as_bind_group(ast: syn::DeriveInput) -> Result<TokenStream> {
let fallback_image = get_fallback_image(&render_path, *dimension); let fallback_image = get_fallback_image(&render_path, *dimension);
binding_impls.push(quote! { // insert fallible texture-based entries at 0 so that if we fail here, we exit before allocating any buffers
binding_impls.insert(0, quote! {
( (
#binding_index, #binding_index,
#render_path::render_resource::OwnedBindingResource::TextureView({ #render_path::render_resource::OwnedBindingResource::TextureView({
@ -353,7 +355,8 @@ pub fn derive_as_bind_group(ast: syn::DeriveInput) -> Result<TokenStream> {
let fallback_image = get_fallback_image(&render_path, *dimension); let fallback_image = get_fallback_image(&render_path, *dimension);
binding_impls.push(quote! { // insert fallible texture-based entries at 0 so that if we fail here, we exit before allocating any buffers
binding_impls.insert(0, quote! {
( (
#binding_index, #binding_index,
#render_path::render_resource::OwnedBindingResource::Sampler({ #render_path::render_resource::OwnedBindingResource::Sampler({