forestia/bevy
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove unnecessary wildcards from LogPlugin and convert warnings to errors. (#12046)

Browse Source 
# Objective

Improve code quality and prevent bugs.

## Solution

I removed the unnecessary wildcards from `<LogPlugin as Plugin>::build`.

I also changed the warnings that would occur if the subscriber/logger
was already set into errors.
This commit is contained in:
Doonv 2024-02-23 20:49:32 +02:00 committed by GitHub
parent bc7ac780fb
commit 2701188f43
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
crates/bevy_log/src/lib.rs
View File

@ -217,12 +217,12 @@ impl Plugin for LogPlugin {
bevy_utils::tracing::subscriber::set_global_default(finished_subscriber).is_err(); bevy_utils::tracing::subscriber::set_global_default(finished_subscriber).is_err();
match (logger_already_set, subscriber_already_set) { match (logger_already_set, subscriber_already_set) {
(true, true) => warn!( (true, true) => error!(
"Could not set global logger and tracing subscriber as they are already set. Consider disabling LogPlugin." "Could not set global logger and tracing subscriber as they are already set. Consider disabling LogPlugin."
), ),
(true, _) => warn!("Could not set global logger as it is already set. Consider disabling LogPlugin."), (true, false) => error!("Could not set global logger as it is already set. Consider disabling LogPlugin."),
(_, true) => warn!("Could not set global tracing subscriber as it is already set. Consider disabling LogPlugin."), (false, true) => error!("Could not set global tracing subscriber as it is already set. Consider disabling LogPlugin."),
_ => (), (false, false) => (),
} }
} }
} }