main_transparent_pass_2d render node command encoding parallelization (#17735)
# Objective - Add command encoding parallelization to transparent 2d pass render node. - Improves https://github.com/bevyengine/bevy/issues/17733 ## Solution Using functionality added in https://github.com/bevyengine/bevy/pull/9172 ## Testing - Tested in personal project where multiple cameras are rendered with objects rendered in transparent 2d pass.
This commit is contained in:
parent
556b750782
commit
2d62026912
@ -4,8 +4,8 @@ use bevy_render::{
|
||||
camera::ExtractedCamera,
|
||||
diagnostic::RecordDiagnostics,
|
||||
render_graph::{NodeRunError, RenderGraphContext, ViewNode},
|
||||
render_phase::ViewSortedRenderPhases,
|
||||
render_resource::{RenderPassDescriptor, StoreOp},
|
||||
render_phase::{TrackedRenderPass, ViewSortedRenderPhases},
|
||||
render_resource::{CommandEncoderDescriptor, RenderPassDescriptor, StoreOp},
|
||||
renderer::RenderContext,
|
||||
view::{ExtractedView, ViewDepthTexture, ViewTarget},
|
||||
};
|
||||
@ -42,14 +42,21 @@ impl ViewNode for MainTransparentPass2dNode {
|
||||
return Ok(());
|
||||
};
|
||||
|
||||
let diagnostics = render_context.diagnostic_recorder();
|
||||
|
||||
render_context.add_command_buffer_generation_task(move |render_device| {
|
||||
// Command encoder setup
|
||||
let mut command_encoder =
|
||||
render_device.create_command_encoder(&CommandEncoderDescriptor {
|
||||
label: Some("main_transparent_pass_2d_command_encoder"),
|
||||
});
|
||||
|
||||
// This needs to run at least once to clear the background color, even if there are no items to render
|
||||
{
|
||||
#[cfg(feature = "trace")]
|
||||
let _main_pass_2d = info_span!("main_transparent_pass_2d").entered();
|
||||
|
||||
let diagnostics = render_context.diagnostic_recorder();
|
||||
|
||||
let mut render_pass = render_context.begin_tracked_render_pass(RenderPassDescriptor {
|
||||
let render_pass = command_encoder.begin_render_pass(&RenderPassDescriptor {
|
||||
label: Some("main_transparent_pass_2d"),
|
||||
color_attachments: &[Some(target.get_color_attachment())],
|
||||
// NOTE: For the transparent pass we load the depth buffer. There should be no
|
||||
@ -62,6 +69,7 @@ impl ViewNode for MainTransparentPass2dNode {
|
||||
timestamp_writes: None,
|
||||
occlusion_query_set: None,
|
||||
});
|
||||
let mut render_pass = TrackedRenderPass::new(&render_device, render_pass);
|
||||
|
||||
let pass_span = diagnostics.pass_span(&mut render_pass, "main_transparent_pass_2d");
|
||||
|
||||
@ -73,8 +81,11 @@ impl ViewNode for MainTransparentPass2dNode {
|
||||
#[cfg(feature = "trace")]
|
||||
let _transparent_main_pass_2d_span =
|
||||
info_span!("transparent_main_pass_2d").entered();
|
||||
if let Err(err) = transparent_phase.render(&mut render_pass, world, view_entity) {
|
||||
error!("Error encountered while rendering the transparent 2D phase {err:?}");
|
||||
if let Err(err) = transparent_phase.render(&mut render_pass, world, view_entity)
|
||||
{
|
||||
error!(
|
||||
"Error encountered while rendering the transparent 2D phase {err:?}"
|
||||
);
|
||||
}
|
||||
}
|
||||
|
||||
@ -95,11 +106,12 @@ impl ViewNode for MainTransparentPass2dNode {
|
||||
occlusion_query_set: None,
|
||||
};
|
||||
|
||||
render_context
|
||||
.command_encoder()
|
||||
.begin_render_pass(&pass_descriptor);
|
||||
command_encoder.begin_render_pass(&pass_descriptor);
|
||||
}
|
||||
|
||||
command_encoder.finish()
|
||||
});
|
||||
|
||||
Ok(())
|
||||
}
|
||||
}
|
||||
|
Loading…
Reference in New Issue
Block a user