forestia/bevy
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Make sure the max window size resize constraint is unset if set to infinity

Browse Source 
The problem here is that if one tries to set the window resize constraint back to e.g. Default::default() where the max window size happens to be infinity then the max window resize constraint won't actually be changed at all, thus making it impossible to actually do this change.

I believe this logic might be copied from the window creation logic over here:
6792cebfd0/crates/bevy_winit/src/winit_windows.rs (L262)

but in that instance the logic makes sense because it is known that the max size constraint will be None, since it's initialized to default at the top of that function.
This commit is contained in:
Martin Sandin 2025-07-10 23:27:49 +02:00 committed by GitHub
parent 6792cebfd0
commit 2d7bd62a56
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
crates/bevy_winit/src/system.rs
View File

@ -439,9 +439,13 @@ pub(crate) fn changed_windows(
};
winit_window.set_min_inner_size(Some(min_inner_size));
if constraints.max_width.is_finite() && constraints.max_height.is_finite() {
winit_window.set_max_inner_size(Some(max_inner_size));
}
winit_window.set_max_inner_size(
if constraints.max_width.is_finite() && constraints.max_height.is_finite() {
Some(max_inner_size)
} else {
None
},
);
}
if window.position != cache.position {