forestia/bevy
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

remove circular dependency between bevy_image and bevy_core_pipeline (#18377)

Browse Source 
# Objective

- https://github.com/bevyengine/bevy/pull/17887 introduced a circular
dependency between bevy_image and bevy_core_pipeline
- This makes it impossible to publish Bevy

## Solution

- Remove the circular dependency, reintroduce the compilation failure
- This failure shouldn't be an issue for users of Bevy, only for users
of subcrates, and can be workaround
- Proper fix should be done with
https://github.com/bevyengine/bevy/issues/17891
- Limited compilation failure is better than publish failure
This commit is contained in:
François Mockers 2025-03-18 01:52:31 +01:00 committed by GitHub
parent 4d8bc6161b
commit 31d2b6539c
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
crates/bevy_image/Cargo.toml
View File

@ -16,7 +16,7 @@ bevy_reflect = ["dep:bevy_reflect", "bevy_math/bevy_reflect"]
# Image formats # Image formats
basis-universal = ["dep:basis-universal"] basis-universal = ["dep:basis-universal"]
bmp = ["image/bmp"] bmp = ["image/bmp"]
dds = ["ddsfile", "bevy_core_pipeline/dds"] dds = ["ddsfile"]
exr = ["image/exr"] exr = ["image/exr"]
ff = ["image/ff"] ff = ["image/ff"]
gif = ["image/gif"] gif = ["image/gif"]
@ -80,7 +80,6 @@ half = { version = "2.4.1" }
[dev-dependencies] [dev-dependencies]
bevy_ecs = { path = "../bevy_ecs", version = "0.16.0-dev" } bevy_ecs = { path = "../bevy_ecs", version = "0.16.0-dev" }
bevy_sprite = { path = "../bevy_sprite", version = "0.16.0-dev" } bevy_sprite = { path = "../bevy_sprite", version = "0.16.0-dev" }
bevy_core_pipeline = { path = "../bevy_core_pipeline", version = "0.16.0-dev" }
[lints] [lints]
workspace = true workspace = true