forestia/bevy
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

bevy_reflect: remove unnecessary const _ around TypePath impl (#19902)

Browse Source 
# Objective

Derived `TypePath` impls have a `const _` block in order to hold a `use
alloc::string::ToString` import. But that import is useless.

Avoiding it helps with https://github.com/bevyengine/bevy/issues/19873.

## Solution

Remove the `use` and `const _`.

## Testing

I used cargo expand to confirm the `const _ ` is no longer produced.

`-Zmacro-stats` output tells me this reduces the size of the `Reflect`
code produced for `bevy_ui` from 1_880_486 bytes to 1_859_634 bytes, a
1.1% drop.
This commit is contained in:
Nicholas Nethercote 2025-07-14 08:38:19 +10:00 committed by GitHub
parent d83bae4417
commit 33bed5dd70
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 20 additions and 27 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
crates/bevy_reflect/derive/src/impls/typed.rs
View File

@ -106,12 +106,6 @@ pub(crate) fn impl_type_path(meta: &ReflectMeta) -> TokenStream {
quote! {
#primitive_assert
// To ensure alloc is available, but also prevent its name from clashing, we place the implementation inside an anonymous constant
const _: () = {
extern crate alloc;
use alloc::string::ToString;
impl #impl_generics #bevy_reflect_path::TypePath for #type_path #ty_generics #where_reflect_clause {
fn type_path() -> &'static str {
#long_type_path
@ -133,7 +127,6 @@ pub(crate) fn impl_type_path(meta: &ReflectMeta) -> TokenStream {
#module_path
}
}
};
}
}