forestia/bevy
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove redundant texture copies in TextureCopyNode (#871)

Browse Source 
Remove redundant texture syncs in TextureCopyNode
This commit is contained in:
rod-salazar 2020-11-16 16:38:14 -08:00 committed by GitHub
parent fcf9d525e1
commit 3fca8c60bb
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 8 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
crates/bevy_render/src/render_graph/nodes/texture_copy_node.rs
View File

@ -6,6 +6,7 @@ use crate::{
use bevy_app::prelude::{EventReader, Events}; use bevy_app::prelude::{EventReader, Events};
use bevy_asset::{AssetEvent, Assets}; use bevy_asset::{AssetEvent, Assets};
use bevy_ecs::{Resources, World}; use bevy_ecs::{Resources, World};
use bevy_utils::{AHashExt, HashSet};
#[derive(Default)] #[derive(Default)]
pub struct TextureCopyNode { pub struct TextureCopyNode {
@ -23,10 +24,15 @@ impl Node for TextureCopyNode {
) { ) {
let texture_events = resources.get::<Events<AssetEvent<Texture>>>().unwrap(); let texture_events = resources.get::<Events<AssetEvent<Texture>>>().unwrap();
let textures = resources.get::<Assets<Texture>>().unwrap(); let textures = resources.get::<Assets<Texture>>().unwrap();
let mut copied_textures = HashSet::new();
for event in self.texture_event_reader.iter(&texture_events) { for event in self.texture_event_reader.iter(&texture_events) {
match event { match event {
AssetEvent::Created { handle } | AssetEvent::Modified { handle } => { AssetEvent::Created { handle } | AssetEvent::Modified { handle } => {
if let Some(texture) = textures.get(handle) { if let Some(texture) = textures.get(handle) {
if copied_textures.contains(&handle.id) {
continue;
}
let texture_descriptor: TextureDescriptor = texture.into(); let texture_descriptor: TextureDescriptor = texture.into();
let width = texture.size.x() as usize; let width = texture.size.x() as usize;
let aligned_width = render_context let aligned_width = render_context
@ -67,6 +73,8 @@ impl Node for TextureCopyNode {
texture_descriptor.size, texture_descriptor.size,
); );
render_context.resources().remove_buffer(texture_buffer); render_context.resources().remove_buffer(texture_buffer);
copied_textures.insert(&handle.id);
} }
} }
AssetEvent::Removed { .. } => {} AssetEvent::Removed { .. } => {}