forestia/bevy
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix timer test to be less reliant on float precision (#3789)

Browse Source 
# Objective

- Test is failing on nightly after the merge of https://github.com/rust-lang/rust/pull/90247
- It was relying on the precision of the duration of `1.0 / 3.0`

## Solution

- Fix the test to be less reliant on float precision to have the same result
This commit is contained in:
François 2022-01-28 16:17:54 +00:00
parent 435fb7af4f
commit 44d09dc46d
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
crates/bevy_core/src/time/timer.rs
View File

@ -469,15 +469,18 @@ mod tests {
#[test] #[test]
fn times_finished_precise() { fn times_finished_precise() {
let mut t = Timer::from_seconds(0.01, true); let mut t = Timer::from_seconds(0.01, true);
let duration = Duration::from_secs_f64(1.0 / 3.0); let duration = Duration::from_secs_f64(0.333);
// total duration: 0.333 => 33 times finished
t.tick(duration); t.tick(duration);
assert_eq!(t.times_finished(), 33); assert_eq!(t.times_finished(), 33);
// total duration: 0.666 => 33 times finished
t.tick(duration); t.tick(duration);
assert_eq!(t.times_finished(), 33); assert_eq!(t.times_finished(), 33);
// total duration: 0.999 => 33 times finished
t.tick(duration); t.tick(duration);
assert_eq!(t.times_finished(), 33); assert_eq!(t.times_finished(), 33);
// It has one additional tick this time to compensate for missing 100th tick // total duration: 1.332 => 34 times finished
t.tick(duration); t.tick(duration);
assert_eq!(t.times_finished(), 34); assert_eq!(t.times_finished(), 34);
} }