From 4c47e31be60611d93d440a2d2f4e43aa8bbd64b2 Mon Sep 17 00:00:00 2001 From: Gino Valente <49806985+MrGVSV@users.noreply.github.com> Date: Mon, 11 Mar 2024 23:19:29 -0700 Subject: [PATCH] bevy_reflect: Remove `U32Visitor` (#12433) # Objective The `U32Visitor` struct has been unused since its introduction in #6140. It's made itself known now by causing a recent [CI failure](https://github.com/bevyengine/bevy/actions/runs/8243333274/job/22543736624). ## Solution Remove the unused `U32Visitor` struct. Also removed `PrepassLightsViewFlush` as it was causing a [similar CI failure](https://github.com/bevyengine/bevy/actions/runs/8243838066/job/22545103746?pr=12433#step:6:269) on this PR. --- crates/bevy_pbr/src/prepass/mod.rs | 3 --- crates/bevy_reflect/src/serde/de.rs | 17 ----------------- 2 files changed, 20 deletions(-) diff --git a/crates/bevy_pbr/src/prepass/mod.rs b/crates/bevy_pbr/src/prepass/mod.rs index 818022b5a7..f8d9ecc188 100644 --- a/crates/bevy_pbr/src/prepass/mod.rs +++ b/crates/bevy_pbr/src/prepass/mod.rs @@ -942,6 +942,3 @@ pub type DrawPrepass = ( SetMaterialBindGroup, DrawMesh, ); - -#[derive(Debug, Hash, PartialEq, Eq, Clone, SystemSet)] -struct PrepassLightsViewFlush; diff --git a/crates/bevy_reflect/src/serde/de.rs b/crates/bevy_reflect/src/serde/de.rs index 8fb1ad44ee..0949085bc4 100644 --- a/crates/bevy_reflect/src/serde/de.rs +++ b/crates/bevy_reflect/src/serde/de.rs @@ -240,23 +240,6 @@ impl<'de> Deserialize<'de> for Ident { } } -struct U32Visitor; - -impl<'de> Visitor<'de> for U32Visitor { - type Value = u32; - - fn expecting(&self, formatter: &mut Formatter) -> fmt::Result { - formatter.write_str("u32") - } - - fn visit_u32(self, v: u32) -> Result - where - E: Error, - { - Ok(v) - } -} - /// A general purpose deserializer for reflected types. /// /// This will return a [`Box`] containing the deserialized data.