forestia/bevy
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix point light shadow glitches (#19265)

Browse Source 
# Objective

Fixes #18945

## Solution

Entities that are not visible in any view (camera or light), get their
render meshes removed. When they become visible somewhere again, the
meshes get recreated and assigned possibly different ids.

Point/spot light visible entities weren't cleared when the lights
themseves went out of view, which caused them to try to queue these fake
visible entities for rendering every frame. The shadow phase cache
usually flushes non visible entites, but because of this bug it never
flushed them and continued to queue meshes with outdated ids.

The simple solution is to every frame clear all visible entities for all
point/spot lights that may or may not be visible. The visible entities
get repopulated directly afterwards. I also renamed the
`global_point_lights` to `global_visible_clusterable` to make it clear
that it includes only visible things.

## Testing

- Tested with the code from the issue.
This commit is contained in:
Eero Lehtinen 2025-05-18 09:24:37 +03:00 committed by GitHub
parent eed1dc428b
commit 4d1b045855
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 14 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
crates/bevy_pbr/src/render/light.rs
View File

@ -220,7 +220,8 @@ pub fn extract_lights(
mut commands: Commands,
point_light_shadow_map: Extract<Res<PointLightShadowMap>>,
directional_light_shadow_map: Extract<Res<DirectionalLightShadowMap>>,
global_point_lights: Extract<Res<GlobalVisibleClusterableObjects>>,
global_visible_clusterable: Extract<Res<GlobalVisibleClusterableObjects>>,
cubemap_visible_entities: Extract<Query<RenderEntity, With<CubemapVisibleEntities>>>,
point_lights: Extract<
Query<(
Entity,
@ -276,6 +277,16 @@ pub fn extract_lights(
if directional_light_shadow_map.is_changed() {
commands.insert_resource(directional_light_shadow_map.clone());
}
// Clear previous visible entities for all cubemapped lights as they might not be in the
// `global_visible_clusterable` list anymore.
commands.try_insert_batch(
cubemap_visible_entities
.iter()
.map(|render_entity| (render_entity, RenderCubemapVisibleEntities::default()))
.collect::<Vec<_>>(),
);
// This is the point light shadow map texel size for one face of the cube as a distance of 1.0
// world unit from the light.
// point_light_texel_size = 2.0 * 1.0 * tan(PI / 4.0) / cube face width in texels
@ -286,7 +297,7 @@ pub fn extract_lights(
let point_light_texel_size = 2.0 / point_light_shadow_map.size as f32;
let mut point_lights_values = Vec::with_capacity(*previous_point_lights_len);
for entity in global_point_lights.iter().copied() {
for entity in global_visible_clusterable.iter().copied() {
let Ok((
main_entity,
render_entity,
@ -350,7 +361,7 @@ pub fn extract_lights(
commands.try_insert_batch(point_lights_values);
let mut spot_lights_values = Vec::with_capacity(*previous_spot_lights_len);
for entity in global_point_lights.iter().copied() {
for entity in global_visible_clusterable.iter().copied() {
if let Ok((
main_entity,
render_entity,