forestia/bevy
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Correctly use as_hsla_f32 in Add<Color> and AddAssign<Color>, fixes #5543 (#5546)

Browse Source 
Probably a copy-paste error, but `Add<Color>` and `AddAssign<Color>` should use `rhs.as_hlsa_f32()` instead of `rhs.as_linear_rgba_f32()` when the LHS is a `Color::Hsla`. Fixes #5543.



Co-authored-by: Verte <105466627+vertesians@users.noreply.github.com>
This commit is contained in:
Verte 2022-08-17 14:00:10 +00:00
parent aed3232e38
commit 56fc1dfe77
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
crates/bevy_render/src/color/mod.rs
View File

@ -745,7 +745,7 @@ impl AddAssign<Color> for Color {
lightness, lightness,
alpha, alpha,
} => { } => {
let rhs = rhs.as_linear_rgba_f32(); let rhs = rhs.as_hsla_f32();
*hue += rhs[0]; *hue += rhs[0];
*saturation += rhs[1]; *saturation += rhs[1];
*lightness += rhs[2]; *lightness += rhs[2];
@ -794,7 +794,7 @@ impl Add<Color> for Color {
lightness, lightness,
alpha, alpha,
} => { } => {
let rhs = rhs.as_linear_rgba_f32(); let rhs = rhs.as_hsla_f32();
Color::Hsla { Color::Hsla {
hue: hue + rhs[0], hue: hue + rhs[0],
saturation: saturation + rhs[1], saturation: saturation + rhs[1],