forestia/bevy
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix flip of contributor bird (#1573)

Browse Source 
Since 89217171b4, some birds in example `contributors` where not colored.

Fix is to use `flip_x` of `Sprite` instead of setting `transform.scale.x` to `-1` as described in #1407.


It may be an unintended side effect, as now we can't easily display a colored sprite while changing it's scale from `1` to `-1`, we would have to change it's scale from `1` to `0`, then flip it, then change scale from `0` to `1`.
This commit is contained in:
François 2021-03-07 19:50:19 +00:00
parent a7308155ee
commit 58d687b86d
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
crates/bevy_sprite/src/render/mod.rs
View File

@ -108,7 +108,7 @@ pub fn build_sprite_pipeline(shaders: &mut Assets<Shader>) -> PipelineDescriptor
topology: PrimitiveTopology::TriangleList, topology: PrimitiveTopology::TriangleList,
strip_index_format: None, strip_index_format: None,
front_face: FrontFace::Ccw, front_face: FrontFace::Ccw,
cull_mode: CullMode::Back, cull_mode: CullMode::None,
polygon_mode: PolygonMode::Fill, polygon_mode: PolygonMode::Fill,
}, },
..PipelineDescriptor::new(ShaderStages { ..PipelineDescriptor::new(ShaderStages {

4
examples/2d/contributors.rs
View File

@ -74,8 +74,7 @@ fn setup(
// some sprites should be flipped // some sprites should be flipped
let flipped = rnd.gen_bool(0.5); let flipped = rnd.gen_bool(0.5);
let mut transform = Transform::from_xyz(pos.0, pos.1, 0.0); let transform = Transform::from_xyz(pos.0, pos.1, 0.0);
transform.scale.x *= if flipped { -1.0 } else { 1.0 };
commands commands
.spawn((Contributor { color: col },)) .spawn((Contributor { color: col },))
@ -87,6 +86,7 @@ fn setup(
sprite: Sprite { sprite: Sprite {
size: Vec2::new(1.0, 1.0) * SPRITE_SIZE, size: Vec2::new(1.0, 1.0) * SPRITE_SIZE,
resize_mode: SpriteResizeMode::Manual, resize_mode: SpriteResizeMode::Manual,
flip_x: flipped,
..Default::default() ..Default::default()
}, },
material: materials.add(ColorMaterial { material: materials.add(ColorMaterial {