From 5eeba1556db4abe682c89386db8aa5fffbca725f Mon Sep 17 00:00:00 2001 From: Isaak Eriksson Date: Fri, 13 Aug 2021 22:21:33 +0000 Subject: [PATCH] Better error message for unsupported shader features Fixes #869 (#2598) # Objective - Provides more useful error messages when using unsupported shader features. ## Solution Fixes #869 - Provided a error message as follows (adding name, set and binding): ``` Unsupported shader bind type CombinedImageSampler (name noiseVol0, set 0, binding 9) ``` --- crates/bevy_render/src/shader/shader_reflect.rs | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/crates/bevy_render/src/shader/shader_reflect.rs b/crates/bevy_render/src/shader/shader_reflect.rs index 9952970e8f..9210c41ef8 100644 --- a/crates/bevy_render/src/shader/shader_reflect.rs +++ b/crates/bevy_render/src/shader/shader_reflect.rs @@ -151,7 +151,19 @@ fn reflect_binding( filtering: true, }, ), - _ => panic!("Unsupported bind type {:?}.", binding.descriptor_type), + _ => { + let ReflectDescriptorBinding { + descriptor_type, + name, + set, + binding, + .. + } = binding; + panic!( + "Unsupported shader bind type {:?} (name '{}', set {}, binding {})", + descriptor_type, name, set, binding + ); + } }; let shader_stage = match shader_stage {