forestia/bevy
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix loading_screen example (#15845)

Browse Source 
# Objective

Since #15641, `loading_screen` panics.

```
called `Result::unwrap()` on an `Err` value: MultipleEntities("bevy_ecs::query::state::QueryState<&mut bevy_render::view::visibility::Visibility, bevy_ecs::query::filter::With<loading_screen::LoadingScreen>>")
```

Before that PR, the camera did not have a `Visibility` component. But
`Visibility` is now a required component of `Camera`. So the query
matches multiple entities.

## Solution

Minimal change to make the example behave like it used to.

Plus a tiny drive-by cleanup to remove a redundant unwrap.

## Testing

`cargo run --example loading_screen`
This commit is contained in:
Rob Parrett 2024-10-10 20:13:33 -07:00 committed by GitHub
parent ae0b7189bf
commit 6701ad25db
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
examples/games/loading_screen.rs
View File

@ -275,15 +275,15 @@ fn load_loading_screen(mut commands: Commands) {
// Determines when to show the loading screen
fn display_loading_screen(
mut loading_screen: Query<&mut Visibility, With<LoadingScreen>>,
mut loading_screen: Query<&mut Visibility, (With<LoadingScreen>, With<Node>)>,
loading_state: Res<LoadingState>,
) {
match loading_state.as_ref() {
LoadingState::LevelLoading => {
*loading_screen.get_single_mut().unwrap() = Visibility::Visible;
}
LoadingState::LevelReady => *loading_screen.get_single_mut().unwrap() = Visibility::Hidden,
let visibility = match loading_state.as_ref() {
LoadingState::LevelLoading => Visibility::Visible,
LoadingState::LevelReady => Visibility::Hidden,
};
*loading_screen.single_mut() = visibility;
}
mod pipelines_ready {