forestia/bevy
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Don't trigger animation events when paused (#15677)

Browse Source 
# Objective

Pausing the `animated_fox` example perfectly as one of the feet hits the
ground causes the event to be triggered every frame.

Context: #15538

## Solution

Don't trigger animation events if the animation is paused.

## Testing

Ran the example, I no longer see the issue.
This commit is contained in:
poopy 2024-10-06 20:57:07 +02:00 committed by GitHub
parent 6edb78a8c3
commit 70269ef758
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 21 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
crates/bevy_animation/src/lib.rs
View File

@ -1143,6 +1143,7 @@ pub fn animate_targets(
continue; continue;
}; };
if !active_animation.paused {
// Trigger all animation events that occurred this tick, if any. // Trigger all animation events that occurred this tick, if any.
if let Some(triggered_events) = TriggeredEvents::from_animation( if let Some(triggered_events) = TriggeredEvents::from_animation(
AnimationEventTarget::Node(target_id), AnimationEventTarget::Node(target_id),
@ -1164,6 +1165,7 @@ pub fn animate_targets(
}); });
} }
} }
}
let Some(curves) = clip.curves_for_target(target_id) else { let Some(curves) = clip.curves_for_target(target_id) else {
continue; continue;