forestia/bevy
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove Sync requirement in Decodable::Decoder (#5819)

Browse Source 
# Objective

- Allow non-`Sync` Decoders
- Unblocks #5422.
- Unblocks harudagondi/bevy_fundsp#1

## Solution

- Remove `Sync` requirement in `Decodable::Decoder`
- This aligns with kira's [`Sound`] and majority of [oddio]'s types (like [`Mixer`]).

[`Sound`]: https://docs.rs/kira/latest/kira/sound/trait.Sound.html
[oddio]: https://docs.rs/oddio/latest/oddio/index.html
[`Mixer`]: https://docs.rs/oddio/latest/oddio/struct.Mixer.html

---

## Changelog

### Changed

- `Decodable::Decoder` now no longer requires `Sync` types.
This commit is contained in:
harudagondi 2022-08-29 23:02:12 +00:00
parent adf2475dab
commit 8a1061209c
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
crates/bevy_audio/src/audio_source.rs
View File

@ -58,7 +58,7 @@ impl AssetLoader for AudioLoader {
/// A type implementing this trait can be decoded as a rodio source /// A type implementing this trait can be decoded as a rodio source
pub trait Decodable: Send + Sync + 'static { pub trait Decodable: Send + Sync + 'static {
/// The decoder that can decode the implementing type /// The decoder that can decode the implementing type
type Decoder: rodio::Source + Send + Sync + Iterator<Item = Self::DecoderItem>; type Decoder: rodio::Source + Send + Iterator<Item = Self::DecoderItem>;
/// A single value given by the decoder /// A single value given by the decoder
type DecoderItem: rodio::Sample + Send + Sync; type DecoderItem: rodio::Sample + Send + Sync;