forestia/bevy
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix asset loader preregistration for multiple assets (#9453)

Browse Source 
# Objective

fix #9452

when multiple assets are queued to a preregistered loader, only one gets
unblocked when the real loader is registered.

## Solution

i thought async_channel receivers worked like broadcast channels, but in
fact the notification is only received by a single receiver, so only a
single waiting asset is unblocked. close the sender instead so that all
blocked receivers are unblocked.
This commit is contained in:
robtfm 2023-08-17 21:56:41 +01:00 committed by GitHub
parent e2ed42fd75
commit 8a8d43d224
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
crates/bevy_asset/src/asset_server.rs
View File

@ -236,7 +236,7 @@ impl AssetServer {
loaders[existing_index] = MaybeAssetLoader::Ready(Arc::new(loader)); loaders[existing_index] = MaybeAssetLoader::Ready(Arc::new(loader));
if let Some(sender) = maybe_sender { if let Some(sender) = maybe_sender {
// notify after replacing the loader // notify after replacing the loader
let _ = sender.send_blocking(()); let _ = sender.close();
} }
} else { } else {
loaders.push(MaybeAssetLoader::Ready(Arc::new(loader))); loaders.push(MaybeAssetLoader::Ready(Arc::new(loader)));