forestia/bevy
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

single parent set for transform propagate (#7869)

Browse Source 
# Objective

- have no system belonging to multiple sets

go from
![before](https://user-images.githubusercontent.com/22177966/222439644-7cf2f84e-0839-4703-a7b4-66ffe92c6aa1.png)
to
![after](https://user-images.githubusercontent.com/22177966/222439747-37872d59-6b8e-4fff-a579-6d40c38f73d3.png)

## Solution

- `propagate_transforms in PropagateTransformSets in TransformSystem::TransformPropagate` instead of
```
propagate_transforms in PropagateTransformSets
propagate_transforms in TransformSystem::TransformPropagate
PropagateTransformsSet is free
```


Co-authored-by: Jakob Hellermann <hellermann@sipgate.de>
This commit is contained in:
Jakob Hellermann 2023-03-02 20:04:03 +00:00
parent 9153bd0e78
commit 8b8078d1d0
1 changed files with 3 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
crates/bevy_transform/src/lib.rs
View File

@ -100,6 +100,7 @@ impl Plugin for TransformPlugin {
.add_plugin(ValidParentCheckPlugin::<GlobalTransform>::default()) .add_plugin(ValidParentCheckPlugin::<GlobalTransform>::default())
// add transform systems to startup so the first update is "correct" // add transform systems to startup so the first update is "correct"
.configure_set(TransformSystem::TransformPropagate.in_base_set(CoreSet::PostUpdate)) .configure_set(TransformSystem::TransformPropagate.in_base_set(CoreSet::PostUpdate))
.configure_set(PropagateTransformsSet.in_set(TransformSystem::TransformPropagate))
.edit_schedule(CoreSchedule::Startup, |schedule| { .edit_schedule(CoreSchedule::Startup, |schedule| {
schedule.configure_set( schedule.configure_set(
TransformSystem::TransformPropagate.in_base_set(StartupSet::PostStartup), TransformSystem::TransformPropagate.in_base_set(StartupSet::PostStartup),
@ -113,20 +114,12 @@ impl Plugin for TransformPlugin {
.in_set(TransformSystem::TransformPropagate) .in_set(TransformSystem::TransformPropagate)
.ambiguous_with(PropagateTransformsSet), .ambiguous_with(PropagateTransformsSet),
) )
.add_startup_system( .add_startup_system(propagate_transforms.in_set(PropagateTransformsSet))
propagate_transforms
.in_set(TransformSystem::TransformPropagate)
.in_set(PropagateTransformsSet),
)
.add_system( .add_system(
sync_simple_transforms sync_simple_transforms
.in_set(TransformSystem::TransformPropagate) .in_set(TransformSystem::TransformPropagate)
.ambiguous_with(PropagateTransformsSet), .ambiguous_with(PropagateTransformsSet),
) )
.add_system( .add_system(propagate_transforms.in_set(PropagateTransformsSet));
propagate_transforms
.in_set(TransformSystem::TransformPropagate)
.in_set(PropagateTransformsSet),
);
} }
} }