From 8f85d4e59895f42cd2d2ecb05b07dab9babe42e6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fran=C3=A7ois=20Mockers?= Date: Fri, 7 Mar 2025 01:18:24 +0100 Subject: [PATCH] rendering regression: mention in pr comment that the solution could be to update the pr (#18153) # Objective - When a PR gets merged that modifies the rendering screenshots, the main reference will be updated - Every in-flight PR will then "fail" rendering change detection as they come from an outdated main branch ## Solution - Suggest updating the PR to the latest main branch --- .github/workflows/example-run-report.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/example-run-report.yml b/.github/workflows/example-run-report.yml index fe2f5a1a18..c2b1e93b02 100644 --- a/.github/workflows/example-run-report.yml +++ b/.github/workflows/example-run-report.yml @@ -104,5 +104,5 @@ jobs: GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} run: | LF=$'\n' - COMMENT_BODY="Your PR caused a change in the graphical output of an example or rendering test. This might be intentional, but it could also mean that something broke! ${LF}You can review it at https://pixel-eagle.com/project/$PROJECT?filter=PR-$PR ${LF} ${LF}If it's expected, please add the M-Deliberate-Rendering-Change label." + COMMENT_BODY="Your PR caused a change in the graphical output of an example or rendering test. This might be intentional, but it could also mean that something broke! ${LF}You can review it at https://pixel-eagle.com/project/$PROJECT?filter=PR-$PR ${LF} ${LF}If it's expected, please add the M-Deliberate-Rendering-Change label. ${LF} ${LF}If this change seems unrelated to your PR, you can consider updating your PR to target the latest main branch, either by rebasing or merging main into it." gh issue comment $PR --body "$COMMENT_BODY"