From 912de69cfbeb69849f8aab6da623b722d7fa30c2 Mon Sep 17 00:00:00 2001 From: ickshonpe Date: Mon, 3 Mar 2025 19:49:52 +0000 Subject: [PATCH] `Val::resolve` doc comment fix (#18143) # Objective Fix the doc comment for `Val::resolve`. It doesn't return a value in logical pixels unless the inputs are also in logical pixels. --- crates/bevy_ui/src/geometry.rs | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/crates/bevy_ui/src/geometry.rs b/crates/bevy_ui/src/geometry.rs index a8b523d696..a5749e467a 100644 --- a/crates/bevy_ui/src/geometry.rs +++ b/crates/bevy_ui/src/geometry.rs @@ -255,7 +255,8 @@ pub enum ValArithmeticError { } impl Val { - /// Resolves a [`Val`] to its value in logical pixels and returns this as an [`f32`]. + /// Resolves a [`Val`] from the given context values and returns this as an [`f32`]. + /// The [`Val::Px`] value (if present), `parent_size` and `viewport_size` should all be in the same coordinate space. /// Returns a [`ValArithmeticError::NonEvaluable`] if the [`Val`] is impossible to resolve into a concrete value. /// /// **Note:** If a [`Val::Px`] is resolved, its inner value is returned unchanged.