forestia/bevy
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix windows not being centered properly when system interface is scaled (#8903)

Browse Source 
# Objective

Fixes #8765 

## Solution

When windows are created during plugin setup, the scale_factor of a
WindowResolution struct will always be 1.0 (default). The correct scale
factor is set later in flow. To get correct center calculations use the
monitors scale factor directly instead.

## Results
System: Windows 10 Pro (125% scaling)
### main 

![scale_125_without_fix](https://github.com/bevyengine/bevy/assets/644930/df808013-adc9-4300-8930-08ac87cc62b8)

### This PR

![scale_125_with_fix](https://github.com/bevyengine/bevy/assets/644930/c3d73606-d9e3-4f65-b4cc-2a1c20dbb64d)
This commit is contained in:
Martin Lysell 2023-06-21 16:00:35 +02:00 committed by GitHub
parent f4fec7b83d
commit 98eb1d56c2
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
crates/bevy_winit/src/winit_windows.rs
View File

@ -345,7 +345,9 @@ pub fn winit_window_position(
if let Some(monitor) = maybe_monitor { if let Some(monitor) = maybe_monitor {
let screen_size = monitor.size(); let screen_size = monitor.size();
let scale_factor = resolution.base_scale_factor(); // We use the monitors scale factor here since WindowResolution.scale_factor
// is not yet populated when windows are created at plugin setup
let scale_factor = monitor.scale_factor();
// Logical to physical window size // Logical to physical window size
let (width, height): (u32, u32) = let (width, height): (u32, u32) =