forestia/bevy
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Use is method instead of downcast_ref::<T>().is_some() in App::is_plugin_added (#11949)

Browse Source 
# Objective

Improve code quality and performance

## Solution

Instead of using `plugin.downcast_ref::<T>().is_some()` in
`App::is_plugin_added`, use `plugin.is::<T>()`. Which is more performant
and cleaner.
This commit is contained in:
Doonv 2024-02-19 00:17:17 +02:00 committed by GitHub
parent c3db02e36e
commit a1ef7be4ac
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
crates/bevy_app/src/app.rs
View File

@ -671,9 +671,7 @@ impl App {
where where
T: Plugin, T: Plugin,
{ {
self.plugin_registry self.plugin_registry.iter().any(|p| p.is::<T>())
.iter()
.any(|p| p.downcast_ref::<T>().is_some())
} }
/// Returns a vector of references to any plugins of type `T` that have been added. /// Returns a vector of references to any plugins of type `T` that have been added.