forestia/bevy
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Make remove_reflect parameter names consistent between ReflectCommandExt and impl for EntityCommands (#19243)

Browse Source 
# Objective

Fix https://github.com/bevyengine/bevy/issues/13390

## Solution

The second parameter of the remove_reflect function is called
component_type_name in ReflectCommandExt but component_type_path in the
implementation for EntityCommands. Use component_type_path in both
places.

## Testing

None
This commit is contained in:
theotherphil 2025-05-26 20:49:56 +01:00 committed by GitHub
parent 923c2ad281
commit a521998eea
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
crates/bevy_ecs/src/reflect/entity_commands.rs
View File

@ -102,7 +102,7 @@ pub trait ReflectCommandExt {
component: Box<dyn PartialReflect>, component: Box<dyn PartialReflect>,
) -> &mut Self; ) -> &mut Self;
/// Removes from the entity the component or bundle with the given type name registered in [`AppTypeRegistry`]. /// Removes from the entity the component or bundle with the given type path registered in [`AppTypeRegistry`].
/// ///
/// If the type is a bundle, it will remove any components in that bundle regardless if the entity /// If the type is a bundle, it will remove any components in that bundle regardless if the entity
/// contains all the components. /// contains all the components.
@ -159,12 +159,12 @@ pub trait ReflectCommandExt {
/// .remove_reflect(prefab.data.reflect_type_path().to_owned()); /// .remove_reflect(prefab.data.reflect_type_path().to_owned());
/// } /// }
/// ``` /// ```
fn remove_reflect(&mut self, component_type_name: impl Into<Cow<'static, str>>) -> &mut Self; fn remove_reflect(&mut self, component_type_path: impl Into<Cow<'static, str>>) -> &mut Self;
/// Same as [`remove_reflect`](ReflectCommandExt::remove_reflect), but using the `T` resource as type registry instead of /// Same as [`remove_reflect`](ReflectCommandExt::remove_reflect), but using the `T` resource as type registry instead of
/// `AppTypeRegistry`. /// `AppTypeRegistry`.
fn remove_reflect_with_registry<T: Resource + AsRef<TypeRegistry>>( fn remove_reflect_with_registry<T: Resource + AsRef<TypeRegistry>>(
&mut self, &mut self,
component_type_name: impl Into<Cow<'static, str>>, component_type_path: impl Into<Cow<'static, str>>,
) -> &mut Self; ) -> &mut Self;
} }
@ -263,7 +263,7 @@ impl<'w> EntityWorldMut<'w> {
self self
} }
/// Removes from the entity the component or bundle with the given type name registered in [`AppTypeRegistry`]. /// Removes from the entity the component or bundle with the given type path registered in [`AppTypeRegistry`].
/// ///
/// If the type is a bundle, it will remove any components in that bundle regardless if the entity /// If the type is a bundle, it will remove any components in that bundle regardless if the entity
/// contains all the components. /// contains all the components.