forestia/bevy
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Make bevy_remote feature enable serialize feature (#17260)

Browse Source 
# Objective

`bevy_remote`'s reflection deserialization basically requires
`ReflectDeserialize` registrations in order to work correctly. In the
context of `bevy` (the library), this means that using `bevy_remote`
without using the `serialize` feature is a footgun, since
`#[reflect(Serialize)]` etc. are gated behind this feature.

The goal of this PR is to avoid this mistake by default.

## Solution

Make the `bevy_remote` feature enable the `serialize` feature, so that
it works as expected.

---

## Migration Guide

The `bevy_remote` feature of `bevy` now enables the `serialize` feature
automatically. If you wish to use `bevy_remote` without enabling the
`serialize` feature for Bevy subcrates, you must import `bevy_remote` on
its own.
This commit is contained in:
Matty Weatherley 2025-01-10 15:31:41 -05:00 committed by GitHub
parent 454dd27922
commit a5279d340d
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
crates/bevy_internal/Cargo.toml
View File

@ -220,7 +220,7 @@ meshlet_processor = ["bevy_pbr?/meshlet_processor"]
bevy_dev_tools = ["dep:bevy_dev_tools"] bevy_dev_tools = ["dep:bevy_dev_tools"]
# Enable support for the Bevy Remote Protocol # Enable support for the Bevy Remote Protocol
bevy_remote = ["dep:bevy_remote"] bevy_remote = ["dep:bevy_remote", "serialize"]
# Provides picking functionality # Provides picking functionality
bevy_picking = ["dep:bevy_picking"] bevy_picking = ["dep:bevy_picking"]