forestia/bevy
2
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Fix ecs example thread_rng duplicate creation (#14795)

Browse Source 
# Objective

While looking through the changes #14782 will create I noticed this.

## Solution

Reuse the existing thread_rng. As this is a code change I would like to
not include it in a pure lint enable PR.

## Testing

I did not test this change (other than the automated CI with this PR). I
think it should be a fairly simple change that can be reviewed only by
the code.
This commit is contained in:
EdJoPaTo 2024-08-19 23:46:42 +02:00 committed by GitHub
parent 618cf7f51d
commit a6d233981d
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
examples/ecs/observer_propagation.rs
View File

@ -69,9 +69,9 @@ struct Armor(u16);
/// A normal bevy system that attacks a piece of the goblin's armor on a timer. /// A normal bevy system that attacks a piece of the goblin's armor on a timer.
fn attack_armor(entities: Query<Entity, With<Armor>>, mut commands: Commands) { fn attack_armor(entities: Query<Entity, With<Armor>>, mut commands: Commands) {
let mut rng = rand::thread_rng(); let mut rng = thread_rng();
if let Some(target) = entities.iter().choose(&mut rng) { if let Some(target) = entities.iter().choose(&mut rng) {
let damage = thread_rng().gen_range(1..20); let damage = rng.gen_range(1..20);
commands.trigger_targets(Attack { damage }, target); commands.trigger_targets(Attack { damage }, target);
info!("⚔️ Attack for {} damage", damage); info!("⚔️ Attack for {} damage", damage);
} }