forestia/bevy
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix animation transitions affecting other entities (#18572)

Browse Source 
## Objective

 Fix #18557.

## Solution

As described in the bug, `remaining_weight` should have been inside the
loop.

## Testing

Locally changed the `animated_mesh_control` example to spawn multiple
meshes and play different transitions.
This commit is contained in:
Greeble 2025-03-27 21:33:25 +00:00 committed by GitHub
parent a08760b19b
commit a7e6578733
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
crates/bevy_animation/src/transition.rs
View File

@ -118,8 +118,9 @@ pub fn advance_transitions(
// is divided between all the other layers, eventually culminating in the // is divided between all the other layers, eventually culminating in the
// currently-playing animation receiving whatever's left. This results in a // currently-playing animation receiving whatever's left. This results in a
// nicely normalized weight. // nicely normalized weight.
let mut remaining_weight = 1.0;
for (mut animation_transitions, mut player) in query.iter_mut() { for (mut animation_transitions, mut player) in query.iter_mut() {
let mut remaining_weight = 1.0;
for transition in &mut animation_transitions.transitions.iter_mut().rev() { for transition in &mut animation_transitions.transitions.iter_mut().rev() {
// Decrease weight. // Decrease weight.
transition.current_weight = (transition.current_weight transition.current_weight = (transition.current_weight