forestia/bevy
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Ensure dds enables bevy_core_pipeline/dds in bevy_anti_aliasing (#18484)

Browse Source 
# Objective

- Compile failure with `bevy_anti_aliasing` due to `dds` feature not
enabling `bevy_core_pipeline/dds`, causing a public API desync.

## Solution

- Ensured feature is enabled

## Testing

- CI
This commit is contained in:
Zachary Harrold 2025-03-22 23:27:14 +11:00 committed by GitHub
parent e3968e2963
commit a8568f7535
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 4 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
crates/bevy_anti_aliasing/Cargo.toml
View File

@ -12,7 +12,7 @@ keywords = ["bevy"]
trace = [] trace = []
webgl = [] webgl = []
webgpu = [] webgpu = []
dds = ["bevy_render/dds", "bevy_image/dds"] dds = ["bevy_render/dds", "bevy_image/dds", "bevy_core_pipeline/dds"]
smaa_luts = ["bevy_render/ktx2", "bevy_image/ktx2", "bevy_image/zstd"] smaa_luts = ["bevy_render/ktx2", "bevy_image/ktx2", "bevy_image/zstd"]
[dependencies] [dependencies]

10
crates/bevy_image/src/image.rs
View File

@ -931,13 +931,9 @@ impl Image {
#[cfg(all(debug_assertions, feature = "dds"))] name: String, #[cfg(all(debug_assertions, feature = "dds"))] name: String,
buffer: &[u8], buffer: &[u8],
image_type: ImageType, image_type: ImageType,
#[expect( #[cfg_attr(
clippy::allow_attributes, not(any(feature = "basis-universal", feature = "dds", feature = "ktx2")),
reason = "`unused_variables` may not always lint" expect(unused_variables, reason = "only used with certain features")
)]
#[allow(
unused_variables,
reason = "`supported_compressed_formats` is needed where the image format is `Basis`, `Dds`, or `Ktx2`; if these are disabled, then `supported_compressed_formats` is unused."
)] )]
supported_compressed_formats: CompressedImageFormats, supported_compressed_formats: CompressedImageFormats,
is_srgb: bool, is_srgb: bool,