From a919cb0a17a842f4ccd0ffb91d5bf9dc76abd14b Mon Sep 17 00:00:00 2001 From: Mike Date: Fri, 2 Feb 2024 21:04:57 -0800 Subject: [PATCH] Don't auto insert on the extract schedule (#11669) # Objective - In #9822 I forgot to disable auto sync points on the Extract Schedule. We want to do this because the Commands on the Extract Schedule should be applied on the render thread. --- crates/bevy_render/src/lib.rs | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/crates/bevy_render/src/lib.rs b/crates/bevy_render/src/lib.rs index 656ba9e12a..d159bb94eb 100644 --- a/crates/bevy_render/src/lib.rs +++ b/crates/bevy_render/src/lib.rs @@ -43,6 +43,8 @@ pub mod prelude { }; } +use bevy_ecs::schedule::ScheduleBuildSettings; +use bevy_utils::prelude::default; pub use extract_param::Extract; use bevy_hierarchy::ValidParentCheckPlugin; @@ -388,6 +390,12 @@ unsafe fn initialize_render_app(app: &mut App) { render_app.main_schedule_label = Render.intern(); let mut extract_schedule = Schedule::new(ExtractSchedule); + // We skip applying any commands during the ExtractSchedule + // so commands can be applied on the render thread. + extract_schedule.set_build_settings(ScheduleBuildSettings { + auto_insert_apply_deferred: false, + ..default() + }); extract_schedule.set_apply_final_deferred(false); render_app