forestia/bevy
2
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Remove unnecessary scopes in App methods (#7813)

Browse Source 
# Objective

A couple of places in `bevy_app` use a scoped block that doesn't do anything. I imagine these are a relic from when `Mut<T>` implemented `Drop` in the early days of bevy.

## Solution

Remove the scopes.
This commit is contained in:
JoJoJet 2023-02-25 05:08:00 +00:00
parent b8263b55fb
commit af4b95c4e8
1 changed files with 4 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
crates/bevy_app/src/app.rs
View File

@ -849,10 +849,8 @@ impl App {
/// See [`bevy_reflect::TypeRegistry::register`]. /// See [`bevy_reflect::TypeRegistry::register`].
#[cfg(feature = "bevy_reflect")] #[cfg(feature = "bevy_reflect")]
pub fn register_type<T: bevy_reflect::GetTypeRegistration>(&mut self) -> &mut Self { pub fn register_type<T: bevy_reflect::GetTypeRegistration>(&mut self) -> &mut Self {
{ let registry = self.world.resource_mut::<AppTypeRegistry>();
let registry = self.world.resource_mut::<AppTypeRegistry>(); registry.write().register::<T>();
registry.write().register::<T>();
}
self self
} }
@ -882,10 +880,8 @@ impl App {
>( >(
&mut self, &mut self,
) -> &mut Self { ) -> &mut Self {
{ let registry = self.world.resource_mut::<AppTypeRegistry>();
let registry = self.world.resource_mut::<AppTypeRegistry>(); registry.write().register_type_data::<T, D>();
registry.write().register_type_data::<T, D>();
}
self self
} }