forestia/bevy
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Refresh RenderVisibilityRanges when a visibility range is removed from the scene. (#16467)

Browse Source 
We have an early-out to avoid updating `RenderVisibilityRanges` when a
`VisibilityRange` component is *modified*, but not when one is
*removed*. This means that removing `VisibilityRange` from an entity
might not update the rendering.

This PR fixes the issue by adding a check for removed
`VisibilityRange`s.
This commit is contained in:
Patrick Walton 2024-11-22 10:17:17 -08:00 committed by François Mockers
parent c11972c3fd
commit b319c56e3c
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
crates/bevy_render/src/view/visibility/range.rs
View File

@ -12,6 +12,7 @@ use bevy_ecs::{
entity::{Entity, EntityHashMap}, entity::{Entity, EntityHashMap},
query::{Changed, With}, query::{Changed, With},
reflect::ReflectComponent, reflect::ReflectComponent,
removal_detection::RemovedComponents,
schedule::IntoSystemConfigs as _, schedule::IntoSystemConfigs as _,
system::{Query, Res, ResMut, Resource}, system::{Query, Res, ResMut, Resource},
}; };
@ -416,8 +417,9 @@ pub fn extract_visibility_ranges(
mut render_visibility_ranges: ResMut<RenderVisibilityRanges>, mut render_visibility_ranges: ResMut<RenderVisibilityRanges>,
visibility_ranges_query: Extract<Query<(Entity, &VisibilityRange)>>, visibility_ranges_query: Extract<Query<(Entity, &VisibilityRange)>>,
changed_ranges_query: Extract<Query<Entity, Changed<VisibilityRange>>>, changed_ranges_query: Extract<Query<Entity, Changed<VisibilityRange>>>,
mut removed_visibility_ranges: Extract<RemovedComponents<VisibilityRange>>,
) { ) {
if changed_ranges_query.is_empty() { if changed_ranges_query.is_empty() && removed_visibility_ranges.read().next().is_none() {
return; return;
} }