forestia/bevy
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix and improve tracy rendering spans (#18588)

Browse Source 
* `submit_graph_commands` was incorrectly timing the command buffer
generation tasks as well, and not only the queue submission. Moved the
span to fix that.
* Added a new `command_buffer_generation_tasks` span as a parent for all
the individual command buffer generation tasks that don't run as part of
the Core3d span.


![image](https://github.com/user-attachments/assets/5a20c2f5-f1df-4c03-afbb-4865327aea33)
This commit is contained in:
JMS55 2025-03-27 22:35:47 -07:00 committed by GitHub
parent f4a5e8bc51
commit b3c83465b3
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 9 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
crates/bevy_render/src/renderer/graph_runner.rs
View File

@ -87,10 +87,10 @@ impl RenderGraphRunner {
finalizer(render_context.command_encoder());
let (render_device, mut diagnostics_recorder) = {
let (commands, render_device, diagnostics_recorder) = render_context.finish();
#[cfg(feature = "trace")]
let _span = info_span!("submit_graph_commands").entered();
let (commands, render_device, diagnostics_recorder) = render_context.finish();
queue.submit(commands);
(render_device, diagnostics_recorder)

7
crates/bevy_render/src/renderer/mod.rs
View File

@ -498,6 +498,10 @@ impl<'w> RenderContext<'w> {
let mut command_buffers = Vec::with_capacity(self.command_buffer_queue.len());
#[cfg(feature = "trace")]
let _command_buffer_generation_tasks_span =
info_span!("command_buffer_generation_tasks").entered();
#[cfg(not(all(target_arch = "wasm32", target_feature = "atomics")))]
{
let mut task_based_command_buffers = ComputeTaskPool::get().scope(|task_pool| {
@ -537,6 +541,9 @@ impl<'w> RenderContext<'w> {
}
}
#[cfg(feature = "trace")]
drop(_command_buffer_generation_tasks_span);
command_buffers.sort_unstable_by_key(|(i, _)| *i);
let mut command_buffers = command_buffers