forestia/bevy
2
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Make Children constructor pub(crate). (#5532)

Browse Source 
#4197 intended to remove all `pub` constructors of `Children` and `Parent` and it seems like this one was missed.

Co-authored-by: devil-ira <justthecooldude@gmail.com>
This commit is contained in:
ira 2022-08-05 03:49:12 +00:00
parent 54750deddd
commit c37939d322
2 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
crates/bevy_hierarchy/src/child_builder.rs
View File

@ -414,7 +414,7 @@ impl<'w> BuildWorldChildren for EntityMut<'w> {
.retain(|value| !children.contains(value)); .retain(|value| !children.contains(value));
children_component.0.extend(children.iter().cloned()); children_component.0.extend(children.iter().cloned());
} else { } else {
self.insert(Children::with(children)); self.insert(Children::from_entities(children));
} }
self self
} }
@ -435,7 +435,7 @@ impl<'w> BuildWorldChildren for EntityMut<'w> {
.retain(|value| !children.contains(value)); .retain(|value| !children.contains(value));
children_component.0.insert_from_slice(index, children); children_component.0.insert_from_slice(index, children);
} else { } else {
self.insert(Children::with(children)); self.insert(Children::from_entities(children));
} }
self self
} }
@ -479,7 +479,7 @@ impl<'w> BuildWorldChildren for WorldChildBuilder<'w> {
} else { } else {
self.world self.world
.entity_mut(parent) .entity_mut(parent)
.insert(Children::with(children)); .insert(Children::from_entities(children));
} }
self self
} }
@ -497,7 +497,7 @@ impl<'w> BuildWorldChildren for WorldChildBuilder<'w> {
} else { } else {
self.world self.world
.entity_mut(parent) .entity_mut(parent)
.insert(Children::with(children)); .insert(Children::from_entities(children));
} }
self self
} }

8
crates/bevy_hierarchy/src/components/children.rs
View File

@ -36,12 +36,12 @@ impl FromWorld for Children {
} }
impl Children { impl Children {
/// Builds and returns a [`Children`] component with the given entities /// Constructs a [`Children`] component with the given entities.
pub fn with(entity: &[Entity]) -> Self { pub(crate) fn from_entities(entities: &[Entity]) -> Self {
Self(SmallVec::from_slice(entity)) Self(SmallVec::from_slice(entities))
} }
/// Swaps the child at `a_index` with the child at `b_index` /// Swaps the child at `a_index` with the child at `b_index`.
pub fn swap(&mut self, a_index: usize, b_index: usize) { pub fn swap(&mut self, a_index: usize, b_index: usize) {
self.0.swap(a_index, b_index); self.0.swap(a_index, b_index);
} }