forestia/bevy
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Skip camera look ups in queue uinodes (#17668)

Browse Source 
# Objective

`queue_uinodes` looks up the `ExtractedView` for every extracted UI
node, but there's no need to look it up again if consecutive nodes have
the same `extracted_camera_entity`.

## Solution

In queue uinodes reuse the previously looked up extracted view if the
`extracted_camera_entity` doesn't change

## Showcase

```
cargo run --example many_buttons --release --features "trace_tracy"
```

<img width="521" alt="queue-ui-improvement"
src="https://github.com/user-attachments/assets/2f111837-8c2e-4a6d-94cd-3c3462c58bc9"
/>

yellow is this PR, red is main
This commit is contained in:
ickshonpe 2025-03-23 09:42:44 +00:00 committed by GitHub
parent a090e2fd47
commit c3f72ba4ad
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 23 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

37
crates/bevy_ui/src/render/mod.rs
View File

@ -946,26 +946,34 @@ pub fn queue_uinodes(
ui_pipeline: Res<UiPipeline>, ui_pipeline: Res<UiPipeline>,
mut pipelines: ResMut<SpecializedRenderPipelines<UiPipeline>>, mut pipelines: ResMut<SpecializedRenderPipelines<UiPipeline>>,
mut transparent_render_phases: ResMut<ViewSortedRenderPhases<TransparentUi>>, mut transparent_render_phases: ResMut<ViewSortedRenderPhases<TransparentUi>>,
mut render_views: Query<(&UiCameraView, Option<&UiAntiAlias>), With<ExtractedView>>, render_views: Query<(&UiCameraView, Option<&UiAntiAlias>), With<ExtractedView>>,
camera_views: Query<&ExtractedView>, camera_views: Query<&ExtractedView>,
pipeline_cache: Res<PipelineCache>, pipeline_cache: Res<PipelineCache>,
draw_functions: Res<DrawFunctions<TransparentUi>>, draw_functions: Res<DrawFunctions<TransparentUi>>,
) { ) {
let draw_function = draw_functions.read().id::<DrawUi>(); let draw_function = draw_functions.read().id::<DrawUi>();
let mut current_camera_entity = Entity::PLACEHOLDER;
let mut current_phase = None;
for (index, extracted_uinode) in extracted_uinodes.uinodes.iter().enumerate() { for (index, extracted_uinode) in extracted_uinodes.uinodes.iter().enumerate() {
let entity = extracted_uinode.render_entity; if current_camera_entity != extracted_uinode.extracted_camera_entity {
let Ok((default_camera_view, ui_anti_alias)) = current_phase = render_views
render_views.get_mut(extracted_uinode.extracted_camera_entity) .get(extracted_uinode.extracted_camera_entity)
else { .ok()
continue; .and_then(|(default_camera_view, ui_anti_alias)| {
}; camera_views
.get(default_camera_view.0)
.ok()
.and_then(|view| {
transparent_render_phases
.get_mut(&view.retained_view_entity)
.map(|transparent_phase| (view, ui_anti_alias, transparent_phase))
})
});
current_camera_entity = extracted_uinode.extracted_camera_entity;
}
let Ok(view) = camera_views.get(default_camera_view.0) else { let Some((view, ui_anti_alias, transparent_phase)) = current_phase.as_mut() else {
continue;
};
let Some(transparent_phase) = transparent_render_phases.get_mut(&view.retained_view_entity)
else {
continue; continue;
}; };
@ -977,10 +985,11 @@ pub fn queue_uinodes(
anti_alias: matches!(ui_anti_alias, None | Some(UiAntiAlias::On)), anti_alias: matches!(ui_anti_alias, None | Some(UiAntiAlias::On)),
}, },
); );
transparent_phase.add(TransparentUi { transparent_phase.add(TransparentUi {
draw_function, draw_function,
pipeline, pipeline,
entity: (entity, extracted_uinode.main_entity), entity: (extracted_uinode.render_entity, extracted_uinode.main_entity),
sort_key: FloatOrd(extracted_uinode.stack_index as f32 + stack_z_offsets::NODE), sort_key: FloatOrd(extracted_uinode.stack_index as f32 + stack_z_offsets::NODE),
index, index,
// batch_range will be calculated in prepare_uinodes // batch_range will be calculated in prepare_uinodes