forestia/bevy
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix TAA on camera with viewport (#14582)

Browse Source 
# Objective

Closes #14526 

## Solution

The history texture was being created incorrectly with the viewport size
rather than target size. When viewport < target, this meant that the
render attachments would differer in size which causes a wgpu validation
error.

## Testing

Example in linked issue works.
This commit is contained in:
charlotte 2024-08-07 16:59:38 -07:00 committed by François
parent 216dba23cb
commit c661da1d42
No known key found for this signature in database
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
crates/bevy_core_pipeline/src/taa/mod.rs
View File

@ -402,13 +402,13 @@ fn prepare_taa_history_textures(
views: Query<(Entity, &ExtractedCamera, &ExtractedView), With<TemporalAntiAliasSettings>>, views: Query<(Entity, &ExtractedCamera, &ExtractedView), With<TemporalAntiAliasSettings>>,
) { ) {
for (entity, camera, view) in &views { for (entity, camera, view) in &views {
if let Some(physical_viewport_size) = camera.physical_viewport_size { if let Some(physical_target_size) = camera.physical_target_size {
let mut texture_descriptor = TextureDescriptor { let mut texture_descriptor = TextureDescriptor {
label: None, label: None,
size: Extent3d { size: Extent3d {
depth_or_array_layers: 1, depth_or_array_layers: 1,
width: physical_viewport_size.x, width: physical_target_size.x,
height: physical_viewport_size.y, height: physical_target_size.y,
}, },
mip_level_count: 1, mip_level_count: 1,
sample_count: 1, sample_count: 1,