forestia/bevy
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove ExtractComponent::Out (#15926)

Browse Source 
# Objective

- `C: ExtractComponent` inserts `C::Out` instead of `C`, so we need to
remove `C::Out`. cc #15904.

## Solution

- `C` -> `C::Out`

## Testing

- CAS has `<ContrastAdaptiveSharpening as ExtractComponent>::Out =
(DenoiseCas, CasUniform)`. Setting its strength to zero correctly
removes the effect after this change.
This commit is contained in:
akimakinai 2024-10-16 08:42:35 +09:00 committed by GitHub
parent ed351294ec
commit c78886e649
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
crates/bevy_render/src/extract_component.rs
View File

@ -207,7 +207,7 @@ fn extract_components<C: ExtractComponent>(
if let Some(component) = C::extract_component(query_item) {
values.push((entity, component));
} else {
commands.entity(entity).remove::<C>();
commands.entity(entity).remove::<C::Out>();
}
}
*previous_len = values.len();
@ -226,7 +226,7 @@ fn extract_visible_components<C: ExtractComponent>(
if let Some(component) = C::extract_component(query_item) {
values.push((entity, component));
} else {
commands.entity(entity).remove::<C>();
commands.entity(entity).remove::<C::Out>();
}
}
}