Change default tonemapping method (#8685)
Change the default tonemapping method from ReinhardLuminance to TonyMcMapface, which generally looks nicer and works out of the box with bloom. --- ## Changelog - TonyMcMapface is now the default tonemapper, instead of ReinhardLuminance. ## Migration Guide - The default tonemapper has been changed from ReinhardLuminance to TonyMcMapface. Explicitly set ReinhardLuminance on your cameras to get back the previous look.
This commit is contained in:
parent
1b6de76bfb
commit
c8deedb0e1
@ -134,9 +134,7 @@ pub enum Tonemapping {
|
|||||||
/// Suffers from lots hue shifting, brights don't desaturate naturally.
|
/// Suffers from lots hue shifting, brights don't desaturate naturally.
|
||||||
/// Bright primaries and secondaries don't desaturate at all.
|
/// Bright primaries and secondaries don't desaturate at all.
|
||||||
Reinhard,
|
Reinhard,
|
||||||
/// Current bevy default. Likely to change in the future.
|
|
||||||
/// Suffers from hue shifting. Brights don't desaturate much at all across the spectrum.
|
/// Suffers from hue shifting. Brights don't desaturate much at all across the spectrum.
|
||||||
#[default]
|
|
||||||
ReinhardLuminance,
|
ReinhardLuminance,
|
||||||
/// Same base implementation that Godot 4.0 uses for Tonemap ACES.
|
/// Same base implementation that Godot 4.0 uses for Tonemap ACES.
|
||||||
/// <https://github.com/TheRealMJP/BakingLab/blob/master/BakingLab/ACES.hlsl>
|
/// <https://github.com/TheRealMJP/BakingLab/blob/master/BakingLab/ACES.hlsl>
|
||||||
@ -156,6 +154,7 @@ pub enum Tonemapping {
|
|||||||
/// Designed as a compromise if you want e.g. decent skin tones in low light, but can't afford to re-do your
|
/// Designed as a compromise if you want e.g. decent skin tones in low light, but can't afford to re-do your
|
||||||
/// VFX to look good without hue shifting.
|
/// VFX to look good without hue shifting.
|
||||||
SomewhatBoringDisplayTransform,
|
SomewhatBoringDisplayTransform,
|
||||||
|
/// Current Bevy default.
|
||||||
/// By Tomasz Stachowiak
|
/// By Tomasz Stachowiak
|
||||||
/// <https://github.com/h3r2tic/tony-mc-mapface>
|
/// <https://github.com/h3r2tic/tony-mc-mapface>
|
||||||
/// Very neutral. Subtle but intentional hue shifting. Brights desaturate across the spectrum.
|
/// Very neutral. Subtle but intentional hue shifting. Brights desaturate across the spectrum.
|
||||||
@ -167,6 +166,7 @@ pub enum Tonemapping {
|
|||||||
/// Color hues are preserved during compression, except for a deliberate [Bezold–Brücke shift](https://en.wikipedia.org/wiki/Bezold%E2%80%93Br%C3%BCcke_shift).
|
/// Color hues are preserved during compression, except for a deliberate [Bezold–Brücke shift](https://en.wikipedia.org/wiki/Bezold%E2%80%93Br%C3%BCcke_shift).
|
||||||
/// To avoid posterization, selective desaturation is employed, with care to avoid the [Abney effect](https://en.wikipedia.org/wiki/Abney_effect).
|
/// To avoid posterization, selective desaturation is employed, with care to avoid the [Abney effect](https://en.wikipedia.org/wiki/Abney_effect).
|
||||||
/// NOTE: Requires the `tonemapping_luts` cargo feature.
|
/// NOTE: Requires the `tonemapping_luts` cargo feature.
|
||||||
|
#[default]
|
||||||
TonyMcMapface,
|
TonyMcMapface,
|
||||||
/// Default Filmic Display Transform from blender.
|
/// Default Filmic Display Transform from blender.
|
||||||
/// Somewhat neutral. Suffers from hue shifting. Brights desaturate across the spectrum.
|
/// Somewhat neutral. Suffers from hue shifting. Brights desaturate across the spectrum.
|
||||||
@ -328,7 +328,7 @@ pub fn get_lut_bindings<'a>(
|
|||||||
bindings: [u32; 2],
|
bindings: [u32; 2],
|
||||||
) -> [BindGroupEntry<'a>; 2] {
|
) -> [BindGroupEntry<'a>; 2] {
|
||||||
let image = match tonemapping {
|
let image = match tonemapping {
|
||||||
//AgX lut texture used when tonemapping doesn't need a texture since it's very small (32x32x32)
|
// AgX lut texture used when tonemapping doesn't need a texture since it's very small (32x32x32)
|
||||||
Tonemapping::None
|
Tonemapping::None
|
||||||
| Tonemapping::Reinhard
|
| Tonemapping::Reinhard
|
||||||
| Tonemapping::ReinhardLuminance
|
| Tonemapping::ReinhardLuminance
|
||||||
|
Loading…
Reference in New Issue
Block a user