forestia/bevy
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

don't trigger drag events if there's no movement (#16950)

Browse Source 
# Objective

- Fixes #16571

## Solution

- When position delta is zero, don't trigger `Drag` or `DragOver` events

## Testing

- tested with the code from the issue
This commit is contained in:
François Mockers 2024-12-24 04:15:13 +01:00 committed by François Mockers
parent 49560aeee5
commit d2fbedbe6f
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
crates/bevy_picking/src/events.rs
View File

@ -657,6 +657,10 @@ pub fn pointer_events(
// Emit Drag events to the entities we are dragging // Emit Drag events to the entities we are dragging
for (drag_target, drag) in state.dragging.iter_mut() { for (drag_target, drag) in state.dragging.iter_mut() {
let delta = location.position - drag.latest_pos;
if delta == Vec2::ZERO {
continue; // No need to emit a Drag event if there is no movement
}
let drag_event = Pointer::new( let drag_event = Pointer::new(
*drag_target, *drag_target,
pointer_id, pointer_id,
@ -664,7 +668,7 @@ pub fn pointer_events(
Drag { Drag {
button, button,
distance: location.position - drag.start_pos, distance: location.position - drag.start_pos,
delta: location.position - drag.latest_pos, delta,
}, },
); );
commands.trigger_targets(drag_event.clone(), *drag_target); commands.trigger_targets(drag_event.clone(), *drag_target);